Removed setValueVolatile from ISequence

Author: anokl

Disruptor.PerfTests/OneToOneRawBatchThroughputTest.cpp

@@ -72,10 +72,11 @@ namespace PerfTests
             {
                 processed = m_barrier->waitFor(sequence->value() + 1);
                 sequence->setValue(processed);
-            } while (processed < expected);
+            }
+            while (processed < expected);
 
             m_latch->set();
-            sequence->setValueVolatile(processed);
+            sequence->setValue(processed);
         }
         catch (std::exception& ex)
         {

Disruptor.PerfTests/OneToOneRawThroughputTest.cpp

@@ -94,7 +94,7 @@ namespace PerfTests
             while (processed < expected);
 
             m_latch->set();
-            s.setValueVolatile(processed);
+            s.setValue(processed);
         }
         catch (std::exception& ex)
         {

Disruptor.Tests/SequenceBarrierTestsFixture.cpp

@@ -74,11 +74,6 @@ namespace Tests
         m_sequenceImplementation->setValue(value);
     }
 
-    void SequenceBarrierTestsFixture::CountDownEventSequence::setValueVolatile(std::int64_t value)
-    {
-        m_sequenceImplementation->setValueVolatile(value);
-    }
-
     bool SequenceBarrierTestsFixture::CountDownEventSequence::compareAndSet(std::int64_t expectedSequence, std::int64_t nextSequence)
     {
         return m_sequenceImplementation->compareAndSet(expectedSequence, nextSequence);

Disruptor.Tests/SequenceBarrierTestsFixture.h

@@ -61,8 +61,6 @@ namespace Tests
 
         void setValue(std::int64_t value) override;
 
-        void setValueVolatile(std::int64_t value) override;
-
         bool compareAndSet(std::int64_t expectedSequence, std::int64_t nextSequence) override;
 
         std::int64_t incrementAndGet() override;

Disruptor/FixedSequenceGroup.cpp

@@ -25,11 +25,6 @@ namespace Disruptor
         DISRUPTOR_THROW_NOT_SUPPORTED_EXCEPTION();
     }
 
-    void FixedSequenceGroup::setValueVolatile(std::int64_t /*value*/)
-    {
-        DISRUPTOR_THROW_NOT_SUPPORTED_EXCEPTION();
-    }
-
     bool FixedSequenceGroup::compareAndSet(std::int64_t /*expectedValue*/, std::int64_t /*newValue*/)
     {
         DISRUPTOR_THROW_NOT_SUPPORTED_EXCEPTION();

Disruptor/ISequence.h

@@ -24,13 +24,6 @@ namespace Disruptor
          */ 
         virtual void setValue(std::int64_t value) = 0;
 
-        /**
-         * Performs a volatile write of this sequence.  The intent is a Store/Store barrier between this write and any previous write and a Store/Load barrier between this write and any subsequent volatile read.
-         * 
-         * \param value 
-         */ 
-        virtual void setValueVolatile(std::int64_t value) = 0;
-
         /**
          * Atomically set the value to the given updated value if the current value == the expected value.
          * 

Disruptor/NoOpEventProcessor.h

@@ -97,10 +97,6 @@ namespace Disruptor
         {
         }
 
-        void setValueVolatile(std::int64_t /*value*/) override
-        {
-        }
-
         bool compareAndSet(std::int64_t /*expectedSequence*/, std::int64_t /*nextSequence*/) override
         {
             return false;

Disruptor/Sequence.cpp

@@ -24,11 +24,6 @@ namespace Disruptor
         std::atomic_store_explicit(&m_fieldsValue, value, std::memory_order_release);
     }
 
-    void Sequence::setValueVolatile(std::int64_t value)
-    {
-        m_fieldsValue = value;
-    }
-
     bool Sequence::compareAndSet(std::int64_t expectedSequence, std::int64_t nextSequence)
     {
         return std::atomic_compare_exchange_strong(&m_fieldsValue, &expectedSequence, nextSequence);

Disruptor/Sequence.h

@@ -34,13 +34,6 @@ namespace Disruptor
          */
         void setValue(std::int64_t value) override;
 
-        /**
-         * Performs a volatile write of this sequence. The intent is a Store/Store barrier between this write and any previous write and a Store/Load barrier between this write and any subsequent volatile read.
-         * 
-         * \param value 
-         */
-        void setValueVolatile(std::int64_t value) override;
-
         /**
          * Atomically set the value to the given updated value if the current value == the expected value.
          *
@@ -72,9 +65,9 @@ namespace Disruptor
         static const std::int64_t InitialCursorValue;
 
     private:
-        char padding0[56];
+        char m_padding0[56] = {};
         std::atomic< std::int64_t > m_fieldsValue;
-        char padding1[56];
+        char m_padding1[56] = {};
     };
 
 } // namespace Disruptor

Disruptor/SingleProducerSequencer.h

@@ -99,7 +99,7 @@ namespace Disruptor
 
             if (wrapPoint > cachedGatingSequence || cachedGatingSequence > nextValue)
             {
-                this->m_cursor->setValueVolatile(nextValue);
+                this->m_cursor->setValue(nextValue);
 
                 SpinWait spinWait;
                 std::int64_t minSequence;