Merge branch 'topic/lal_1552' into 'master'

Integer_Types_As_Enum: ignore formal types.

See merge request eng/libadalang/langkit-query-language!542

Author: Roldak

lkql_checker/share/lkql/integer_types_as_enum.lkql

@@ -70,7 +70,7 @@ fun integer_types_as_enum(node) =
     |"       X := 2;
     |"       Y := Y + 1;
     |"    end Proc;
-    node is TypeDecl(p_is_int_type(): true)
+    node is ConcreteTypeDecl(p_is_int_type(): true)
     when not [t for t in types() if t == node]
      and not [t for t in instantiations() if t == node]
      and not [t for t in arithmetic_ops() if t == node]

testsuite/tests/checks/integer_as_enum/generics.adb

@@ -0,0 +1,15 @@
+procedure Generics is
+   generic
+      type T is range <>;      -- NOFLAG
+   package Pkg is
+      -- T is never used as an integer type so in theory it could be flagged
+      -- by this rule. However, we don't want to flag formal types.
+      type U is range 1 .. 3;  -- FLAG
+      -- make sure that concrete type declarations inside generics are still
+      -- flagged though.
+   end Pkg;
+
+   package My_Pkg is new Pkg (Integer);
+begin
+   null;
+end Generics;

testsuite/tests/checks/integer_as_enum/test.out

@@ -2,6 +2,10 @@ bit.adb:2:9: rule violation: integer type may be replaced by an enumeration
 2 |    type Enum is mod 2 ** 8;       --  FLAG
   |         ^^^^
 
+generics.adb:7:12: rule violation: integer type may be replaced by an enumeration
+7 |       type U is range 1 .. 3;  -- FLAG
+  |            ^
+
 op.adb:2:9: rule violation: integer type may be replaced by an enumeration
 2 |    type Enum is range 1 .. 3;    --  FLAG
   |         ^^^^