-
Notifications
You must be signed in to change notification settings - Fork 313
Describe changes to element hiding rules in CoreLibs 1.18 #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8ffb07e
Describe changes to element hiding rules in CoreLibs 1.18
ngorskikh 6c50037
Lint
ngorskikh 0426da0
Edit
ngorskikh ce4a983
Merge branch 'master' into feature/AG-37642
ngorskikh 377c755
Update docs/general/ad-filtering/create-own-filters.md
ngorskikh ad6ebfe
Edit 2
ngorskikh d37e4fa
Merge branch 'master' into feature/AG-37642
ngorskikh c040763
Merge branch 'master' into feature/AG-37642
ngorskikh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3435,6 +3435,28 @@ CSS rules may operate differently [depending on the platform](#cosmetic-rules-pr | |
|
|
||
| ::: | ||
|
|
||
| :::info Adblock Plus compatibility | ||
|
|
||
| In AdGuard products that use **CoreLibs version 1.18 or later**, you can also use element hiding rules to inject CSS. | ||
| For example: | ||
|
|
||
| ```adblock | ||
| example.org##body { background-color: green; } | ||
| abptestpages.org##.testcase-inline-css-ehe {background-color: #c70d2c;} | ||
| ``` | ||
|
|
||
| This usage is discouraged in favor of using [CSS rules](#cosmetic-css-rules) and is only supported for compatibility with filter lists written for Adblock Plus. | ||
|
|
||
| Element hiding exceptions (`#@#`) can match such a rule both by its selector part and by the full rule text. | ||
| For example, the rule `example.org##body { background-color: green; }` can be disabled by any of the following exception rules: | ||
|
|
||
| ```adblock | ||
| example.org#@#body | ||
| example.org#@#body { background-color: green; } | ||
|
||
| ``` | ||
|
|
||
| ::: | ||
|
|
||
| ### Extended CSS selectors {#extended-css-selectors} | ||
|
|
||
| - [Limitations](#extended-css-limitations) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest mentioning remove rules here, such as
example.com##h1 { remove: true; }.Another important point is that in the free version, only remove rules work — as far as I understand, other types of CSS injections (like coloring) are part of the premium ABP subscription.
ABP refers to these rules collectively as “Inline CSS” rules btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, if that's the case, can we limit the support to
remove: trueand just not support their premium functionality? It makes little sense since the rules for that are a part of their premium bundle and it cannot be shared&used in other ad blockers.