Skip to content

Commit 059795e

Browse files
Slachnguyenminhduc9988
authored andcommitted
fix wrong definition of view for 25.8, properly cleanup TestNamedCollections, fix #961
Signed-off-by: Slach <[email protected]>
1 parent c5f282a commit 059795e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/integration/integration_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2142,7 +2142,7 @@ func TestSkipTablesAndSkipTableEngines(t *testing.T) {
21422142
env.queryWithNoError(r, "CREATE DATABASE test_skip_tables")
21432143
env.queryWithNoError(r, "CREATE TABLE IF NOT EXISTS test_skip_tables.test_merge_tree (id UInt64, s String) ENGINE=MergeTree() ORDER BY id")
21442144
env.queryWithNoError(r, "CREATE TABLE IF NOT EXISTS test_skip_tables.test_memory (id UInt64) ENGINE=Memory")
2145-
env.queryWithNoError(r, "CREATE MATERIALIZED VIEW IF NOT EXISTS test_skip_tables.test_mv (id UInt64) ENGINE=MergeTree() ORDER BY id AS SELECT * FROM test_skip_tables.test_merge_tree")
2145+
env.queryWithNoError(r, "CREATE MATERIALIZED VIEW IF NOT EXISTS test_skip_tables.test_mv (id UInt64) ENGINE=MergeTree() ORDER BY id AS SELECT id FROM test_skip_tables.test_merge_tree")
21462146
if compareVersion(os.Getenv("CLICKHOUSE_VERSION"), "21.3") >= 0 {
21472147
query := "CREATE LIVE VIEW IF NOT EXISTS test_skip_tables.test_live_view AS SELECT count() FROM test_skip_tables.test_merge_tree"
21482148
allowExperimentalAnalyzer, err := env.ch.TurnAnalyzerOffIfNecessary(version, query, "")
@@ -3552,7 +3552,8 @@ func TestNamedCollections(t *testing.T) {
35523552
r.NoError(env.dropDatabase("test_named_collection", true))
35533553
})
35543554
}
3555-
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/test_named_collection.csv*")
3555+
env.DockerExecNoError(r, "minio", "rm", "-rf", "/bitnami/minio/data/clickhouse/test_named_collection.csv")
3556+
env.checkObjectStorageIsEmpty(t, r, "S3")
35563557
env.Cleanup(t, r)
35573558
}
35583559

0 commit comments

Comments
 (0)