Skip to content

Commit 18883de

Browse files
committed
venv based commands
1 parent df7b4c3 commit 18883de

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@ jobs:
1414
- name: Install dependencies & test
1515
run: |
1616
sudo apt-get update
17-
sudo apt-get install -y gzip tar zstd python3 python3-pip python3-venv python3-coverage
17+
sudo apt-get install -y gzip tar zstd python3 python3-pip python3-venv
1818
python3 -m venv venv
19-
python3 -m pip install --upgrade pip
20-
pip3 install -r requirements.txt
21-
2219
source venv/bin/activate
20+
python3 -m pip install -r requirements.txt
21+
2322
chmod +x test.sh
2423
./test.sh

test.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ compare_json() {
2727
}
2828

2929
## cleanup
30-
python3-coverage combine
31-
python3-coverage erase
30+
python3 -m coverage combine
31+
python3 -m coverage erase
3232
rm -rf test_data/
3333
tar xvf test_data.tar
3434
mkdir test_data/result
3535

3636
## common failures
37-
fail python3-coverage run -p ./megawarc
38-
fail python3-coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/zstd_bad_name test_data/pack/zstd_bad_name/bad_name.warc.zst
37+
fail python3 -m coverage run -p ./megawarc
38+
fail python3 -m coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/zstd_bad_name test_data/pack/zstd_bad_name/bad_name.warc.zst
3939

4040
## pack zst
41-
pass python3-coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/zstd_valid test_data/pack/zstd_valid/
41+
pass python3 -m coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/zstd_valid test_data/pack/zstd_valid/
4242
# gzip header includes timestamp, so hashes won't match compressed
4343
pass gzip -d -f test_data/result/zstd_valid.1743749844.megawarc.json.gz
4444
compare_json test_data/result_expected/zstd_valid.1743749844.megawarc.json test_data/result/zstd_valid.1743749844.megawarc.json
@@ -47,7 +47,7 @@ pass tar xvf test_data/result/zstd_valid.1743749844.megawarc.tar -C test_data/re
4747
pass sha256sum -c test_data/result_expected/checksums_zstd_valid.txt
4848

4949
## pack gzip
50-
pass python3-coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/gz_valid test_data/pack/gz_valid/
50+
pass python3 -m coverage run -p ./megawarc --verbose pack --server https://legacy-api.arpa.li/dictionary test_data/result/gz_valid test_data/pack/gz_valid/
5151
# gzip header includes timestamp, so hashes won't match compressed
5252
pass gzip -d -k -f test_data/result/gz_valid.megawarc.json.gz
5353
compare_json test_data/result_expected/gz_valid.megawarc.json test_data/result/gz_valid.megawarc.json
@@ -56,19 +56,19 @@ pass tar xvf test_data/result/gz_valid.megawarc.tar -C test_data/result/
5656
pass sha256sum -c test_data/result_expected/checksums_gz_valid.txt
5757

5858
## restore gzip
59-
pass python3-coverage run -p ./megawarc --verbose restore test_data/result/gz_valid
59+
pass python3 -m coverage run -p ./megawarc --verbose restore test_data/result/gz_valid
6060
pass tar xvf test_data/result/gz_valid -C test_data/result/
6161
pass sha256sum -c test_data/result_expected/checksum_gzip_valid_restore.txt
6262

6363
# convert back
6464
rm test_data/result/gz_valid.megawarc*
65-
pass python3-coverage run -p ./megawarc --verbose convert test_data/result/gz_valid
65+
pass python3 -m coverage run -p ./megawarc --verbose convert test_data/result/gz_valid
6666
# gzip header includes timestamp, so hashes won't match compressed
6767
pass gzip -d -k -f test_data/result/gz_valid.megawarc.json.gz
6868
compare_json test_data/result_expected/gz_valid_rebuilt.megawarc.json test_data/result/gz_valid.megawarc.json
6969
# extract rejected files to check their hashes
7070
pass tar xvf test_data/result/gz_valid.megawarc.tar -C test_data/result/
7171
pass sha256sum -c test_data/result_expected/checksums_gz_valid.txt
7272

73-
python3-coverage combine
74-
python3-coverage xml
73+
python3 -m coverage combine
74+
python3 -m coverage xml

0 commit comments

Comments
 (0)