Added post came from. #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some feedback on this in #126 |
tomjn
suggested changes
Mar 11, 2025
| $post_source = get_post_meta( $post->ID, 'syn_source_url', true ); | ||
| if ( isset( $post_source ) && '' !== $post_source ) { | ||
| echo '<div class="syn-post-source">'; | ||
| echo esc_html( sprintf( 'Source: %s', parse_url( $post_source, PHP_URL_HOST ) ), 'push-syndication' ); |
There was a problem hiding this comment.
This looks okay but 2 points:
- There's no internationalisation here for
Source: - If the post source is not empty and not a valid URL then it will return
falseornull, butsprintfis expecting a string, which could lead to some oddness.
There was a problem hiding this comment.
Only took you 7 years, 8 months and 22 days Tom 😂
There was a problem hiding this comment.
I needed to think long and hard about this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature #126