Move default visibility logic to UI and classic editor (#2378)

Author: pfefferle

.github/changelog/2378-from-description

@@ -0,0 +1,4 @@
+Significance: minor
+Type: changed
+
+Moved default visibility handling from the server to the editor UI, ensuring consistent and flexible ActivityPub visibility settings across both block and classic editors.

build/editor-plugin/plugin.asset.php

@@ -1 +1 @@
-<?php return array('dependencies' => array('react-jsx-runtime', 'wp-components', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => '2e0397f8327aae6f3e13');
+<?php return array('dependencies' => array('react-jsx-runtime', 'wp-components', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => 'c0707a36ca43854f47b7');

build/editor-plugin/plugin.js

@@ -36,7 +36,6 @@ public static function init() {
 
 		\add_filter( 'add_post_metadata', array( self::class, 'prevent_empty_post_meta' ), 10, 4 );
 		\add_filter( 'update_post_metadata', array( self::class, 'prevent_empty_post_meta' ), 10, 4 );
-		\add_filter( 'default_post_metadata', array( self::class, 'default_post_meta_data' ), 10, 3 );
 
 		// Add support for ActivityPub to custom post types.
 		foreach ( \get_option( 'activitypub_support_post_types', array( 'post' ) ) as $post_type ) {
@@ -523,6 +522,29 @@ public static function register_activitypub_post_meta() {
 					},
 				)
 			);
+
+			\register_post_meta(
+				$post_type,
+				'activitypub_status',
+				array(
+					'type'              => 'string',
+					'single'            => true,
+					'show_in_rest'      => true,
+					'sanitize_callback' => function ( $value ) {
+						$schema = array(
+							'type'    => 'string',
+							'enum'    => array( 'pending', 'federated', 'failed' ),
+							'default' => 'pending',
+						);
+
+						if ( \is_wp_error( \rest_validate_enum( $value, $schema, '' ) ) ) {
+							return $schema['default'];
+						}
+
+						return $value;
+					},
+				)
+			);
 		}
 	}
 
@@ -578,36 +600,4 @@ public static function prevent_empty_post_meta( $check, $object_id, $meta_key, $
 
 		return $check;
 	}
-
-	/**
-	 * Adjusts default post meta values.
-	 *
-	 * @param mixed  $meta_value The meta value.
-	 * @param int    $object_id  ID of the object metadata is for.
-	 * @param string $meta_key   Metadata key.
-	 *
-	 * @return string|null The meta value.
-	 */
-	public static function default_post_meta_data( $meta_value, $object_id, $meta_key ) {
-		if ( 'activitypub_content_visibility' !== $meta_key ) {
-			return $meta_value;
-		}
-
-		// If meta value is already explicitly set, respect the author's choice.
-		if ( $meta_value ) {
-			return $meta_value;
-		}
-
-		// If the post is federated, return the default visibility.
-		if ( 'federated' === \get_post_meta( $object_id, 'activitypub_status', true ) ) {
-			return $meta_value;
-		}
-
-		// If the post is not federated and older than a month, return local visibility.
-		if ( \get_the_date( 'U', $object_id ) < \strtotime( '-1 month' ) ) {
-			return ACTIVITYPUB_CONTENT_VISIBILITY_LOCAL;
-		}
-
-		return $meta_value;
-	}
 }