Ensure support_post_types option returns an array (#2339)

Author: pfefferle

.github/changelog/2339-from-description

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Added a safeguard to ensure the plugin works correctly even when no post types are selected.

includes/class-options.php

@@ -26,6 +26,7 @@ public static function init() {
 
 		\add_filter( 'default_option_activitypub_negotiate_content', array( self::class, 'default_option_activitypub_negotiate_content' ) );
 		\add_filter( 'option_activitypub_max_image_attachments', array( self::class, 'default_max_image_attachments' ) );
+		\add_filter( 'option_activitypub_support_post_types', array( self::class, 'support_post_types_ensure_array' ) );
 		\add_filter( 'option_activitypub_object_type', array( self::class, 'default_object_type' ) );
 	}
 
@@ -176,6 +177,17 @@ public static function default_max_image_attachments( $value ) {
 		return $value;
 	}
 
+	/**
+	 * Ensure support post types is an array.
+	 *
+	 * @param string[] $value The value of the option.
+	 *
+	 * @return string[] The value of the option.
+	 */
+	public static function support_post_types_ensure_array( $value ) {
+		return (array) $value;
+	}
+
 	/**
 	 * Default object type.
 	 *

includes/wp-admin/class-settings-fields.php

@@ -283,8 +283,8 @@ public static function render_max_image_attachments_field() {
 	 * Render support post types field.
 	 */
 	public static function render_support_post_types_field() {
-		$post_types           = get_post_types( array( 'public' => true ), 'objects' );
-		$supported_post_types = (array) get_option( 'activitypub_support_post_types', array( 'post' ) );
+		$post_types           = \get_post_types( array( 'public' => true ), 'objects' );
+		$supported_post_types = \get_option( 'activitypub_support_post_types', array( 'post' ) );
 		?>
 		<fieldset>
 			<?php esc_html_e( 'Automatically publish items of the selected post types to the fediverse:', 'activitypub' ); ?>

integration/class-wp-rest-cache.php

@@ -101,7 +101,7 @@ public static function transition_post_status( $new_status, $old_status, $post )
 			return;
 		}
 
-		$post_types   = (array) \get_option( 'activitypub_support_post_types', array() );
+		$post_types   = \get_option( 'activitypub_support_post_types', array() );
 		$post_types[] = Outbox::POST_TYPE;
 
 		if ( ! \in_array( $post->post_type, $post_types, true ) ) {