Skip to content

Commit a132299

Browse files
committed
fix: only upload video and traces on failure.
This was accidentally changed in 21ebd32
1 parent 448aaea commit a132299

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/playwright.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
run: make webe2etest
9696

9797
- name: Upload Playwright artifacts
98-
if: always()
98+
if: failure()
9999
uses: actions/upload-artifact@v4
100100
with:
101101
name: playwright-artifacts

frontends/web/playwright.config.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,15 @@ export default defineConfig({
1717
timeout: 120_000,
1818
},
1919
],
20-
timeout: 120_000,
20+
timeout: 180_000,
2121
workers: 1, // Tests are not parallel-safe yet.
2222
use: {
2323
baseURL: `http://${HOST}:${FRONTEND_PORT}`,
2424
headless: true,
25-
video: 'on',
25+
video: 'retain-on-failure',
2626
screenshot: 'only-on-failure',
27-
trace: 'on',
27+
trace: 'retain-on-failure',
28+
bypassCSP: true, // add this to disable cors
2829
launchOptions: {
2930
// By default, tests are not run in slow motion.
3031
// Can be enabled by setting the PLAYWRIGHT_SLOW_MO environment variable to a value > 0.

0 commit comments

Comments
 (0)