[Agent SDK] Sign Request Value Types (#28)

This PR preserves the old functionality by keeping the hex input as it
was (so should not break anything). However, its not entirely clear at
this moment if the newly accepted input will pass transaction
simulation. Will iterate if necessary.

Author: bh2smith

bun.lock

@@ -32,8 +32,8 @@
     "build:cjs": "tsc -p tsconfig.cjs.json"
   },
   "dependencies": {
-    "viem": "^2.21.53",
-    "near-safe": "^0.9.6",
+    "viem": "^2.22.21",
+    "near-safe": "^0.9.10",
     "zerion-sdk": "^0.0.13"
   }
 }

bun.lockb

@@ -1,13 +1,21 @@
 import type { MetaTransaction, SignRequestData } from "near-safe";
 import { NearSafe } from "near-safe";
-import { getAddress, type Hex, zeroAddress, type Address } from "viem";
+import { getAddress, zeroAddress, isHex, toHex, toBytes } from "viem";
+import type { Address, Hex } from "viem";
 
 export * from "./types";
 export * from "./erc20";
 export * from "./weth";
 export * from "./tokens";
 export * from "./safe";
 
+export function hexifyValue(value: string): Hex {
+  if (isHex(value)) {
+    return value;
+  }
+  return toHex(toBytes(BigInt(value)));
+}
+
 export function signRequestFor({
   from,
   chainId,
@@ -20,12 +28,14 @@ export function signRequestFor({
   return {
     method: "eth_sendTransaction",
     chainId,
-    params: metaTransactions.map((mt) => ({
-      from: from ?? zeroAddress,
-      to: getAddress(mt.to),
-      value: mt.value as Hex,
-      data: mt.data as Hex,
-    })),
+    params: metaTransactions.map((mt) => {
+      return {
+        from: from ?? zeroAddress,
+        to: getAddress(mt.to),
+        value: hexifyValue(mt.value),
+        data: mt.data as Hex,
+      };
+    }),
   };
 }
 

packages/agent-sdk/package.json

@@ -54,7 +54,6 @@ export async function getSafeBalances(
   zerionKey?: string,
 ): Promise<TokenBalance[]> {
   const baseUrl = safeTxServiceUrlFor(chainId);
-  console.log(baseUrl);
   if (!baseUrl) {
     console.warn(
       `Chain ID ${chainId} not supported by Safe Transaction Service`,
@@ -66,7 +65,6 @@ export async function getSafeBalances(
   const url = `${baseUrl}/api/v1/safes/${checksumAddress(address)}/balances/?trusted=${trusted}&exclude_spam=${exclude_spam}`;
 
   try {
-    console.log(`Fetching Safe balances for ${address} from ${url}`);
     const response = await fetch(url, {
       headers: {
         accept: "application/json",
@@ -79,7 +77,6 @@ export async function getSafeBalances(
       throw new Error(`HTTP error! status: ${response.status}`);
     }
     const data: TokenBalance[] = await response.json();
-    console.log(`Retrieved ${data.length} balances`);
     return data;
   } catch (error) {
     console.warn("Error fetching Safe balances:", error);

packages/agent-sdk/src/evm/index.ts

@@ -41,12 +41,8 @@ export async function getTokenDetails(
     return getTokenInfo(chainId, symbolOrAddress);
   }
   if (!tokenMap) {
-    console.log(
-      "Loading TokenMap... this should be stored in memory consider setting it with loadTokenMap() in your app and passing it here.",
-    );
     tokenMap = await loadTokenMap();
   }
-  console.log("Seeking TokenMap for Symbol", symbolOrAddress);
   // TokenMap has lower cased (sanitized) symbols
   return tokenMap[chainId][symbolOrAddress.toLowerCase()];
 }

packages/agent-sdk/src/evm/safe.ts

@@ -13,7 +13,6 @@ export async function handleRequest<X, T, R>(
 ): Promise<R> {
   try {
     const result = await logic(input);
-    console.log("Responding with", JSON.stringify(result, null, 2));
     return responseTransformer(result);
   } catch (err: unknown) {
     const message = errorString(err);

packages/agent-sdk/src/evm/tokens.ts

@@ -3,28 +3,44 @@ import {
   fallbackResponder,
   validateRequest,
 } from "../../src/evm";
-import { zeroAddress } from "viem";
+import { getAddress, zeroAddress } from "viem";
 import { NextRequest, NextResponse } from "next/server";
 import type { BaseRequest } from "../../src/evm";
+import { hexifyValue } from "../../src/evm";
 
-// Mock external dependencies
-jest.mock("viem", () => ({
-  getAddress: jest.fn().mockImplementation((address) => address),
-  zeroAddress: "0x0000000000000000000000000000000000000000",
-}));
+const address = (i: number): `0x${string}` =>
+  getAddress(`0x${i.toString(16).padStart(40, "0")}`);
+
+const to = address(123);
+const from = address(456);
 
 jest.mock("near-safe", () => ({
   NearSafe: {
     create: jest.fn().mockImplementation(async () => ({
-      address: "0x123",
+      address: to,
     })),
   },
 }));
 
 describe("evm/index", () => {
+  describe("hexifyValue", () => {
+    it("does the thing", () => {
+      expect(hexifyValue("0x00")).toEqual("0x00");
+
+      expect(hexifyValue("0")).toEqual("0x00");
+      expect(hexifyValue("1")).toEqual("0x01");
+      expect(hexifyValue("15")).toEqual("0x0f");
+      expect(hexifyValue("16")).toEqual("0x10");
+      expect(hexifyValue("17")).toEqual("0x11");
+      expect(hexifyValue("255")).toEqual("0xff");
+      expect(hexifyValue("256")).toEqual("0x0100");
+      expect(hexifyValue("257")).toEqual("0x0101");
+      expect(hexifyValue("256")).toEqual("0x0100");
+    });
+  });
   describe("signRequestFor", () => {
     it("creates a sign request with default from address", () => {
-      const metaTransactions = [{ to: "0x123", value: "0x0", data: "0xabc" }];
+      const metaTransactions = [{ to, value: "0x00", data: "0xabc" }];
 
       const result = signRequestFor({
         chainId: 1,
@@ -37,19 +53,19 @@ describe("evm/index", () => {
         params: [
           {
             from: zeroAddress,
-            to: "0x123",
-            value: "0x0",
+            to,
+            value: "0x00",
             data: "0xabc",
           },
         ],
       });
     });
 
     it("creates a sign request with specified from address", () => {
-      const metaTransactions = [{ to: "0x123", value: "0x0", data: "0xabc" }];
+      const metaTransactions = [{ to, value: "0x0", data: "0xabc" }];
 
       const result = signRequestFor({
-        from: "0x456",
+        from,
         chainId: 1,
         metaTransactions,
       });
@@ -59,8 +75,8 @@ describe("evm/index", () => {
         chainId: 1,
         params: [
           {
-            from: "0x456",
-            to: "0x123",
+            from,
+            to,
             value: "0x0",
             data: "0xabc",
           },
@@ -132,7 +148,7 @@ describe("evm/index", () => {
         headers: {
           get: jest.fn().mockReturnValue(
             JSON.stringify({
-              evmAddress: "0x123",
+              evmAddress: address(123),
             }),
           ),
         },

packages/agent-sdk/src/request.ts

@@ -103,7 +103,6 @@ describe("getSafeBalances", () => {
       1,
       "0x54F08c27e75BeA0cdDdb8aA9D69FD61551B19BbA",
     );
-    console.log(result);
     expect(result).toEqual({
       balances: [
         {