Skip to content

Commit 1131938

Browse files
authored
[patch] try logging into npm (#1090)
# Pull Request Template ## Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Unit test - [ ] Integration test ## JS Budget Check Please mention the size in kb before abd after this PR | Files | Before | After | | ----------- | ----------- | ----------- | | dist/build.js. | | | | dist/build.min.js| | | ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings ## Mentions: List the person or team responsible for reviewing proposed changes. cc @BranchMetrics/saas-sdk-devs for visibility.
1 parent acba1f9 commit 1131938

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

.github/workflows/deploy-release.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ name: Publish Next Release (Manual)
22

33
on:
44
workflow_dispatch:
5-
inputs:
6-
ref:
7-
description: Reference git commit to release (e.g. "master", "12341fa")
8-
required: true
9-
default: master
105

116
env:
127
NODE_VERSION: 18
@@ -16,8 +11,6 @@ jobs:
1611
runs-on: ubuntu-latest
1712
steps:
1813
- uses: actions/checkout@v4
19-
with:
20-
ref: ${{ github.event.inputs.ref }}
2114

2215
- name: AWS, credentials setup
2316
uses: aws-actions/configure-aws-credentials@v4
@@ -28,7 +21,7 @@ jobs:
2821

2922
- name: Add INPUT_SHA env var
3023
run: |
31-
export INPUT_SHA=$(git rev-parse ${{ github.event.inputs.ref }})
24+
export INPUT_SHA=$(git rev-parse ${{ github.ref }})
3225
echo "INPUT_SHA=`echo $INPUT_SHA`" >> $GITHUB_ENV
3326
3427
- name: Install branch-github-actions
@@ -60,6 +53,7 @@ jobs:
6053
uses: actions/setup-node@v4
6154
with:
6255
node-version: ${{ env.NODE_VERSION }}
56+
registry-url: 'https://registry.npmjs.org'
6357

6458
# Do this before npm configure because it writes the package.json version
6559
- name: Write version to files

0 commit comments

Comments
 (0)