Skip to content

Commit 47d0eb6

Browse files
committed
Last commit cleaning up real(0.1,cvmix_r8) calls
Most of these are just legibility changes... using cvmix_one instead of real(1,cvmix_r8) over and over again.
1 parent 9751d1f commit 47d0eb6

File tree

5 files changed

+18
-14
lines changed

5 files changed

+18
-14
lines changed

src/shared/cvmix_convection.F90

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,16 @@ module cvmix_convection
6565
private
6666
! Convective diff
6767
! diffusivity coefficient used in convective regime
68-
real(cvmix_r8) :: convect_diff ! units: m^2/s
68+
real(cvmix_r8) :: convect_diff ! units: m^2/s
69+
6970
! viscosity coefficient used in convective regime
7071
real(cvmix_r8) :: convect_visc ! units: m^2/s
7172
logical :: lBruntVaisala
73+
7274
! Threshold for squared buoyancy frequency needed to trigger
7375
! Brunt-Vaisala parameterization
7476
real(cvmix_r8) :: BVsqr_convect ! units: s^-2
77+
7578
! Flag for what to do with old values of CVmix_vars%[MTS]diff
7679
integer :: handle_old_vals
7780
end type cvmix_conv_params_type

src/shared/cvmix_ddiff.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -419,8 +419,8 @@ subroutine cvmix_coeffs_ddiff_low(Tdiff_out, Sdiff_out, strat_param_num, &
419419
CVmix_ddiff_params_in%kappa_ddiff_param3* &
420420
(cvmix_one/Rrho-cvmix_one)))
421421
case ("K88")
422-
ddiff = CVmix_ddiff_params_in%mol_diff * real(8.7,cvmix_r8) * &
423-
(Rrho**real(1.1,cvmix_r8))
422+
ddiff = CVmix_ddiff_params_in%mol_diff * 8.7_cvmix_r8 * &
423+
(Rrho**1.1_cvmix_r8)
424424
case DEFAULT
425425
print*, "ERROR: ", trim(CVmix_ddiff_params_in%diff_conv_type), &
426426
" is not a valid value for diff_conv_type"

src/shared/cvmix_kinds_and_types.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ module cvmix_kinds_and_types
3939
! Global parameters:
4040
! The constant 1 is used repeatedly in PP and double-diff mixing.
4141
! The value for pi is needed for Bryan-Lewis mixing.
42-
real(cvmix_r8), parameter, public :: cvmix_zero = 0.0_cvmix_r8, &
43-
cvmix_one = 1.0_cvmix_r8
42+
real(cvmix_r8), parameter, public :: cvmix_zero = real(0,cvmix_r8), &
43+
cvmix_one = real(1,cvmix_r8)
4444
real(cvmix_r8), parameter, public :: cvmix_PI = &
4545
3.14159265358979323846_cvmix_r8
4646

src/shared/cvmix_kpp.F90

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,7 +1512,7 @@ subroutine cvmix_kpp_compute_nonlocal(shape_fun, sigma, nonlocal, &
15121512
GatS = cvmix_math_evaluate_cubic(shape_fun, sigma)
15131513

15141514
nonlocal = GatS*(Cstar*vonkar*(vonkar*surf_layer_ext*c_s)** &
1515-
(real(1,cvmix_r8)/real(3,cvmix_r8)))
1515+
(cvmix_one/real(3,cvmix_r8)))
15161516
! EOC
15171517

15181518
end subroutine cvmix_kpp_compute_nonlocal
@@ -1831,7 +1831,7 @@ subroutine cvmix_kpp_compute_turbulent_scales_1d_sigma(sigma_coord, &
18311831
vonkar * surf_buoy_force
18321832
! w_m = vonkar * u* / phi_m
18331833
! = vonkar * ((u*/phi_m)^3)^1/3
1834-
w_m(kw) = vonkar*(w_m(kw)**(real(1,cvmix_r8)/real(3,cvmix_r8)))
1834+
w_m(kw) = vonkar*(w_m(kw)**(cvmix_one/real(3,cvmix_r8)))
18351835
end do
18361836
end if ! surf_buoy_force >= 0
18371837
end if ! compute_wm
@@ -1850,7 +1850,7 @@ subroutine cvmix_kpp_compute_turbulent_scales_1d_sigma(sigma_coord, &
18501850
vonkar * surf_buoy_force
18511851
! w_s = vonkar * u* / phi_s
18521852
! = vonkar * ((u*/phi_s)^3)^1/3
1853-
w_s(kw) = vonkar*(w_s(kw)**(real(1,cvmix_r8)/real(3,cvmix_r8)))
1853+
w_s(kw) = vonkar*(w_s(kw)**(cvmix_one/real(3,cvmix_r8)))
18541854
end do
18551855
end if ! surf_buoy_force >= 0
18561856
end if ! compute_ws
@@ -1962,7 +1962,7 @@ subroutine cvmix_kpp_compute_turbulent_scales_1d_OBL(sigma_coord, &
19621962
vonkar * surf_buoy_force(kw)
19631963
! w_m = vonkar * u* / phi_m
19641964
! = vonkar * ((u*/phi_m)^3)^1/3
1965-
w_m(kw) = vonkar*(w_m(kw)**(real(1,cvmix_r8)/real(3,cvmix_r8)))
1965+
w_m(kw) = vonkar*(w_m(kw)**(cvmix_one/real(3,cvmix_r8)))
19661966
endif
19671967
end do
19681968
end if ! compute_wm
@@ -1982,7 +1982,7 @@ subroutine cvmix_kpp_compute_turbulent_scales_1d_OBL(sigma_coord, &
19821982
vonkar * surf_buoy_force(kw)
19831983
! w_s = vonkar * u* / phi_s
19841984
! = vonkar * ((u*/phi_s)^3)^1/3
1985-
w_s(kw) = vonkar*(w_s(kw)**(real(1,cvmix_r8)/real(3,cvmix_r8)))
1985+
w_s(kw) = vonkar*(w_s(kw)**(cvmix_one/real(3,cvmix_r8)))
19861986
end if ! surf_buoy_force >= 0
19871987
end do
19881988
end if ! compute_ws

src/shared/cvmix_math.F90

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ module cvmix_math
2222

2323
! !USES:
2424

25-
use cvmix_kinds_and_types, only : cvmix_r8
25+
use cvmix_kinds_and_types, only : cvmix_r8, &
26+
cvmix_one
2627

2728
!EOP
2829

@@ -111,9 +112,9 @@ subroutine cvmix_math_poly_interp(coeffs, interp_type, x, y, x0, y0)
111112
rhs(3) = 0.0_cvmix_r8
112113
end if
113114

114-
Minv(1,1) = -real(1, cvmix_r8)/det
115-
Minv(1,2) = real(1, cvmix_r8)/det
116-
Minv(1,3) = -real(1, cvmix_r8)/(x(2)-x(1))
115+
Minv(1,1) = -cvmix_one/det
116+
Minv(1,2) = cvmix_one/det
117+
Minv(1,3) = -cvmix_one/(x(2)-x(1))
117118
Minv(2,1) = real(2, cvmix_r8)*x(1)/det
118119
Minv(2,2) = -real(2, cvmix_r8)*x(1)/det
119120
Minv(2,3) = (x(2)+x(1))/(x(2)-x(1))

0 commit comments

Comments
 (0)