Restrict retry to be only callable by allowed address (#625)

Co-authored-by: mace <[email protected]>

Author: Matija Petrunić

contracts/Bridge.sol

@@ -381,10 +381,12 @@ contract Bridge is Pausable, Context {
 
     /**
         @notice This method is used to trigger the process for retrying failed deposits on the MPC side.
+        @notice Only callable by address that has the right to call the specific function,
+        which is mapped in {functionAccess} in AccessControlSegregator contract.
         @param txHash Transaction hash which contains deposit that should be retried
         @notice This is not applicable for failed executions on {GenericHandler}
      */
-    function retry(string memory txHash) external {
+    function retry(string memory txHash) external onlyAllowed {
         emit Retry(txHash);
     }
 

test/contractBridge/admin.js

@@ -23,6 +23,7 @@ contract('Bridge - [admin]', async (accounts) => {
     const someAddress = "0xcafecafecafecafecafecafecafecafecafecafe";
     const nullAddress = "0x0000000000000000000000000000000000000000";
     const topologyHash = "549f715f5b06809ada23145c2dc548db";
+    const txHash = "0x59d881e01ca682130e550e3576b6de760951fb45b1d5dd81342132f57920bbfa";
 
     const bytes32 = "0x0";
     let ADMIN_ROLE;
@@ -241,4 +242,18 @@ contract('Bridge - [admin]', async (accounts) => {
         await assertOnlyAdmin(BridgeInstance.adminChangeAccessControl, someAddress)
     })
 
+    // Retry
+
+    it('Should require admin role to retry deposit', async () => {
+        await assertOnlyAdmin(BridgeInstance.retry, txHash);
+    });
+
+    it('Should successfully emit Retry event', async () => {
+        const eventTx = await BridgeInstance.retry(txHash);
+
+        TruffleAssert.eventEmitted(eventTx, 'Retry', (event) => {
+            return event.txHash === txHash
+        });
+    });
+
 });

test/contractBridge/publicMethods.js

@@ -236,9 +236,10 @@ const deployBridge = async (domainID, admin) => {
             "0x6ba6db6b", // startKeygen
             "0xd2e5fae9", // endKeygen
             "0xd8236744", // refreshKey
+            "0x366b4885", // retry
 
         ],
-        Array(13).fill(admin)
+        Array(14).fill(admin)
     )
     return await BridgeContract.new(domainID, accessControlInstance.address);
 }