fix: resolve mixed value/pointer receivers

- convert all CollatorProtocolMessage methods to pointer receivers
- convert all CollationFetchingResponse methods to pointer receivers
- convert all CollationProtocol methods to pointer receivers
- remove unused receiver variable names

Resolves DeepSource issue GO-W1029

Author: Yuri0405

dot/parachain/collator-protocol/messages/protocol_messages.go

@@ -39,7 +39,7 @@ func (mvdt *CollationProtocol) SetValue(value any) (err error) {
 	}
 }
 
-func (mvdt CollationProtocol) IndexValue() (index uint, value any, err error) {
+func (mvdt *CollationProtocol) IndexValue() (index uint, value any, err error) {
 	switch mvdt.inner.(type) {
 	case CollatorProtocolMessage:
 		return 0, mvdt.inner, nil
@@ -48,7 +48,7 @@ func (mvdt CollationProtocol) IndexValue() (index uint, value any, err error) {
 	return 0, nil, scale.ErrUnsupportedVaryingDataTypeValue
 }
 
-func (mvdt CollationProtocol) Value() (value any, err error) {
+func (mvdt *CollationProtocol) Value() (value any, err error) {
 	_, value, err = mvdt.IndexValue()
 	return
 }
@@ -103,7 +103,7 @@ func (mvdt *CollatorProtocolMessage) SetValue(value any) (err error) {
 	}
 }
 
-func (mvdt CollatorProtocolMessage) IndexValue() (index uint, value any, err error) {
+func (mvdt *CollatorProtocolMessage) IndexValue() (index uint, value any, err error) {
 	switch mvdt.inner.(type) {
 	case Declare:
 		return 0, mvdt.inner, nil
@@ -121,7 +121,7 @@ func (mvdt CollatorProtocolMessage) IndexValue() (index uint, value any, err err
 	return 0, nil, scale.ErrUnsupportedVaryingDataTypeValue
 }
 
-func (mvdt CollatorProtocolMessage) Value() (value any, err error) {
+func (mvdt *CollatorProtocolMessage) Value() (value any, err error) {
 	_, value, err = mvdt.IndexValue()
 	return
 }
@@ -176,12 +176,12 @@ type CollationSeconded struct {
 }
 
 // Type returns CollationMsgType
-func (CollationProtocol) Type() network.MessageType {
+func (*CollationProtocol) Type() network.MessageType {
 	return network.CollationMsgType
 }
 
 // Hash returns the hash of the CollationProtocolV1
-func (cp CollationProtocol) Hash() (common.Hash, error) {
+func (cp *CollationProtocol) Hash() (common.Hash, error) {
 	// scale encode each extrinsic
 	encMsg, err := cp.Encode()
 	if err != nil {
@@ -192,7 +192,7 @@ func (cp CollationProtocol) Hash() (common.Hash, error) {
 }
 
 // Encode a collator protocol message using scale encode
-func (cp CollationProtocol) Encode() ([]byte, error) {
+func (cp *CollationProtocol) Encode() ([]byte, error) {
 	enc, err := scale.Marshal(cp)
 	if err != nil {
 		return nil, err

dot/parachain/collator-protocol/validator-side/collation_fetching.go

@@ -75,7 +75,7 @@ func (mvdt *CollationFetchingResponse) SetValue(value any) (err error) {
 	}
 }
 
-func (mvdt CollationFetchingResponse) IndexValue() (index uint, value any, err error) {
+func (mvdt *CollationFetchingResponse) IndexValue() (index uint, value any, err error) {
 	switch mvdt.inner.(type) {
 	case parachaintypes.Collation:
 		return 0, mvdt.inner, nil
@@ -84,7 +84,7 @@ func (mvdt CollationFetchingResponse) IndexValue() (index uint, value any, err e
 	return 0, nil, scale.ErrUnsupportedVaryingDataTypeValue
 }
 
-func (mvdt CollationFetchingResponse) Value() (value any, err error) {
+func (mvdt *CollationFetchingResponse) Value() (value any, err error) {
 	_, value, err = mvdt.IndexValue()
 	return
 }