Skip to content

Commit 6e2c20c

Browse files
committed
feat(parachain): Auto-detect V2 peers from AdvertiseCollationV2 (#4711)
- Upgrade peer to ProtocolV2 when receiving V2 advertisement - Remove redundant V1 default in PeerConnected handler - Complete automatic version detection for collation requests
1 parent e5198e0 commit 6e2c20c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

dot/parachain/collator-protocol/message.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,9 @@ func (cpvs *CollatorProtocolValidatorSide) processCollatorProtocolMessage(sender
446446
return fmt.Errorf("handling v2 advertisement: %w", err)
447447
}
448448

449+
logger.Debugf("Peer %s sent V2 advertisement, upgrading to ProtocolV2", sender)
450+
cpvs.setPeerProtocolVersion(sender, ProtocolV2)
451+
449452
case 4: // CollationSeconded
450453
logger.Errorf("unexpected collation seconded message from peer %s, decreasing its reputation", sender)
451454
cpvs.SubSystemToOverseer <- networkbridgemessages.ReportPeer{

dot/parachain/collator-protocol/validator_side.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -869,8 +869,6 @@ func (cpvs *CollatorProtocolValidatorSide) handleNetworkBridgeEvents(msg any) er
869869
Instant: time.Now(),
870870
},
871871
}
872-
// Default to V1, will upgrade if we detect V2 capabilities later
873-
cpvs.setPeerProtocolVersion(msg.PeerID, ProtocolV1)
874872
}
875873
case networkbridgeevents.PeerDisconnected:
876874
delete(cpvs.peerData, msg.PeerID)

0 commit comments

Comments
 (0)