Mark node and nodes field shareable when in source schema mode (#8857)

Author: michaelstaib

src/HotChocolate/AspNetCore/benchmarks/k6/dataloader.js

@@ -4,9 +4,9 @@ import exec from 'k6/execution';
 
 export const options = {
   stages: [
-    { duration: '10s', target: 10 },
-    { duration: '20s', target: 100 },
-    { duration: '1m', target: 100 },
+    { duration: '10s', target: 50 },
+    { duration: '20s', target: 500 },
+    { duration: '1m', target: 500 },
   ],
   thresholds: {
     'http_req_duration{phase:measurement}': ['p(95)<500', 'p(99)<1000'],

src/HotChocolate/AspNetCore/benchmarks/k6/performance-data.json

@@ -1,20 +1,20 @@
 {
-  "timestamp": "2025-10-30T15:41:52Z",
+  "timestamp": "2025-10-31T06:56:49Z",
   "tests": {
     "single-fetch": {
       "name": "Single Fetch (50 products, names only)",
       "response_time": {
-        "min": 0.8121,
-        "p50": 2.019409,
-        "max": 34.259858,
-        "avg": 2.016368485854345,
-        "p90": 2.7201433000000006,
-        "p95": 2.9610656499999988,
-        "p99": 6.065892389999998
+        "min": 0.747831,
+        "p50": 1.510499,
+        "max": 61.819994,
+        "avg": 2.1072153114973546,
+        "p90": 3.5390032,
+        "p95": 4.891518000000001,
+        "p99": 9.782994420000009
       },
       "throughput": {
-        "requests_per_second": 78.82362001703528,
-        "total_iterations": 7171
+        "requests_per_second": 394.21092824371044,
+        "total_iterations": 35874
       },
       "reliability": {
         "error_rate": 0
@@ -23,17 +23,17 @@
     "dataloader": {
       "name": "DataLoader (50 products with brands)",
       "response_time": {
-        "min": 1.666098,
-        "p50": 3.1525455,
-        "max": 16.3474,
-        "avg": 3.2837058709677325,
-        "p90": 4.254632300000001,
-        "p95": 4.88343795,
-        "p99": 9.383130000000001
+        "min": 1.656751,
+        "p50": 3.009085,
+        "max": 47.328823,
+        "avg": 4.203039777054027,
+        "p90": 8.029613,
+        "p95": 12.6258765,
+        "p99": 17.829473200000006
       },
       "throughput": {
-        "requests_per_second": 78.69012270107648,
-        "total_iterations": 7161
+        "requests_per_second": 393.37936798247773,
+        "total_iterations": 35802
       },
       "reliability": {
         "error_rate": 0

src/HotChocolate/AspNetCore/benchmarks/k6/single-fetch.js

@@ -4,9 +4,9 @@ import exec from 'k6/execution';
 
 export const options = {
   stages: [
-    { duration: '10s', target: 10 },
-    { duration: '20s', target: 100 },
-    { duration: '1m', target: 100 },
+    { duration: '10s', target: 50 },
+    { duration: '20s', target: 500 },
+    { duration: '1m', target: 500 },
   ],
   thresholds: {
     'http_req_duration{phase:measurement}': ['p(95)<500', 'p(99)<1000'],

src/HotChocolate/Core/src/Execution/DependencyInjection/RequestExecutorBuilderExtensions.Composite.cs

@@ -22,5 +22,6 @@ public static IRequestExecutorBuilder AddSourceSchemaDefaults(
         {
             o.ApplyShareableToConnections = true;
             o.ApplyShareableToPageInfo = true;
+            o.ApplyShareableToNodeFields = true;
         });
 }

src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs

@@ -216,4 +216,10 @@ public interface IReadOnlySchemaOptions
     /// Applies the @sharable directive to all connection and edge types.
     /// </summary>
     bool ApplyShareableToConnections { get; }
+
+    /// <summary>
+    /// Applies the @sharable directive to the `node(id)` and `nodes(id)`
+    /// field when Global Object Identification is turned on.
+    /// </summary>
+    bool ApplyShareableToNodeFields { get; }
 }

src/HotChocolate/Core/src/Types/SchemaOptions.cs

@@ -183,6 +183,9 @@ public int OperationDocumentCacheSize
     /// <inheritdoc cref="IReadOnlySchemaOptions.ApplyShareableToConnections"/>
     public bool ApplyShareableToConnections { get; set; }
 
+    /// <inheritdoc cref="IReadOnlySchemaOptions.ApplyShareableToNodeFields"/>
+    public bool ApplyShareableToNodeFields { get; set; }
+
     /// <summary>
     /// Creates a mutable options object from a read-only options object.
     /// </summary>
@@ -222,6 +225,7 @@ public static SchemaOptions FromOptions(IReadOnlySchemaOptions options)
             PreparedOperationCacheSize = options.PreparedOperationCacheSize,
             OperationDocumentCacheSize = options.OperationDocumentCacheSize,
             ApplyShareableToPageInfo = options.ApplyShareableToPageInfo,
-            ApplyShareableToConnections = options.ApplyShareableToConnections
+            ApplyShareableToConnections = options.ApplyShareableToConnections,
+            ApplyShareableToNodeFields =  options.ApplyShareableToNodeFields
         };
 }

src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldTypeInterceptor.cs

@@ -5,7 +5,6 @@
 using HotChocolate.Types.Composite;
 using HotChocolate.Types.Descriptors;
 using HotChocolate.Types.Descriptors.Configurations;
-using HotChocolate.Types.Helpers;
 using HotChocolate.Utilities;
 using static HotChocolate.Properties.TypeResources;
 using static HotChocolate.Types.Relay.NodeConstants;
@@ -22,8 +21,10 @@ internal sealed class NodeFieldTypeInterceptor : TypeInterceptor
     private ObjectTypeConfiguration? _queryTypeConfig;
     private TypeReference _nodeType = null!;
     private TypeReference _lookupRef = null!;
+    private TypeReference _shareableRef = null!;
     private bool _registeredTypes;
     private GlobalObjectIdentificationOptions _options = null!;
+    private IReadOnlySchemaOptions _schemaOptions = null!;
 
     internal override uint Position => uint.MaxValue - 100;
 
@@ -42,7 +43,9 @@ internal override void InitializeContext(
     {
         _nodeType = context.TypeInspector.GetTypeRef(typeof(NodeType));
         _lookupRef = context.TypeInspector.GetTypeRef(typeof(Lookup));
+        _shareableRef = context.TypeInspector.GetTypeRef(typeof(Shareable));
         _options = context.Features.GetRequired<NodeSchemaFeature>().Options;
+        _schemaOptions = context.Options;
     }
 
     public override IEnumerable<TypeReference> RegisterMoreTypes(
@@ -57,6 +60,11 @@ public override IEnumerable<TypeReference> RegisterMoreTypes(
                 yield return _lookupRef;
             }
 
+            if (_options.MarkNodeFieldAsLookup || _schemaOptions.ApplyShareableToNodeFields)
+            {
+                yield return _shareableRef;
+            }
+
             _registeredTypes = true;
         }
     }
@@ -78,7 +86,6 @@ public override void OnBeforeCompleteTypes()
         if (_queryContext is not null && _queryTypeConfig is not null)
         {
             var typeInspector = _queryContext.TypeInspector;
-
             var serializer = _queryContext.DescriptorContext.NodeIdSerializerAccessor;
 
             // the nodes fields shall be chained in after the introspection fields,
@@ -94,7 +101,8 @@ public override void OnBeforeCompleteTypes()
                 serializer,
                 _queryTypeConfig.Fields,
                 index + 1,
-                _options.MarkNodeFieldAsLookup);
+                _options.MarkNodeFieldAsLookup,
+                _schemaOptions.ApplyShareableToNodeFields);
 
             if (_options.AddNodesField)
             {
@@ -103,7 +111,8 @@ public override void OnBeforeCompleteTypes()
                     serializer,
                     _queryTypeConfig.Fields,
                     index + 2,
-                    maxAllowedNodes);
+                    maxAllowedNodes,
+                    _schemaOptions.ApplyShareableToNodeFields);
             }
         }
     }
@@ -113,7 +122,8 @@ private static void CreateNodeField(
         INodeIdSerializerAccessor serializerAccessor,
         IList<ObjectFieldConfiguration> fields,
         int index,
-        bool markNodeFieldAsLookup)
+        bool markNodeFieldAsLookup,
+        bool markNodeFieldSharable)
     {
         var node = typeInspector.GetTypeRef(typeof(NodeType));
         var id = typeInspector.GetTypeRef(typeof(NonNullType<IdType>));
@@ -123,7 +133,10 @@ private static void CreateNodeField(
             Relay_NodeField_Description,
             node)
         {
-            Arguments = { new ArgumentConfiguration(Id, Relay_NodeField_Id_Description, id) },
+            Arguments =
+            {
+                new ArgumentConfiguration(Id, Relay_NodeField_Id_Description, id)
+            },
             MiddlewareConfigurations =
             {
                 new FieldMiddlewareConfiguration(_ =>
@@ -144,6 +157,11 @@ private static void CreateNodeField(
             field.AddDirective(Lookup.Instance, typeInspector);
         }
 
+        if (markNodeFieldSharable || markNodeFieldAsLookup)
+        {
+            field.AddDirective(Shareable.Instance, typeInspector);
+        }
+
         // In the projection interceptor we want to change the context data on this field
         // after the field is completed. We need at least 1 element on the context data to avoid
         // it being replaced with ReadOnlyFeatureCollection.Default
@@ -157,7 +175,8 @@ private static void CreateNodesField(
         INodeIdSerializerAccessor serializerAccessor,
         IList<ObjectFieldConfiguration> fields,
         int index,
-        int maxAllowedNodes)
+        int maxAllowedNodes,
+        bool markNodeFieldSharable)
     {
         var nodes = typeInspector.GetTypeRef(typeof(NonNullType<ListType<NodeType>>));
         var ids = typeInspector.GetTypeRef(typeof(NonNullType<ListType<NonNullType<IdType>>>));
@@ -167,7 +186,10 @@ private static void CreateNodesField(
             Relay_NodesField_Description,
             nodes)
         {
-            Arguments = { new ArgumentConfiguration(Ids, Relay_NodesField_Ids_Description, ids) },
+            Arguments =
+            {
+                new ArgumentConfiguration(Ids, Relay_NodesField_Ids_Description, ids)
+            },
             MiddlewareConfigurations =
             {
                 new FieldMiddlewareConfiguration(_ =>
@@ -183,6 +205,11 @@ private static void CreateNodesField(
             Flags = CoreFieldFlags.ParallelExecutable | CoreFieldFlags.GlobalIdNodesField
         };
 
+        if (markNodeFieldSharable)
+        {
+            field.AddDirective(Shareable.Instance, typeInspector);
+        }
+
         // In the projection interceptor we want to change the context data on this field
         // after the field is completed. We need at least 1 element on the context data to avoid
         // it being replaced with ReadOnlyFeatureCollection.Default.

src/HotChocolate/Core/test/Authorization.Tests/__snapshots__/AnnotationBasedAuthorizationTests.Authorize_Node_Field_Schema.graphql

@@ -26,7 +26,7 @@ type Person implements Node @authorize(policy: "READ_PERSON", apply: AFTER_RESOL
 
 type Query @foo @authorize(policy: "QUERY", apply: VALIDATION) @authorize(policy: "QUERY2") {
   "Fetches an object given its ID."
-  node("ID of the object." id: ID!): Node @lookup @cost(weight: "10") @authorize(policy: "READ_NODE", apply: VALIDATION)
+  node("ID of the object." id: ID!): Node @lookup @shareable @cost(weight: "10") @authorize(policy: "READ_NODE", apply: VALIDATION)
   "Lookup nodes by a list of IDs."
   nodes("The list of node IDs." ids: [ID!]!): [Node]! @cost(weight: "10") @authorize(policy: "READ_NODE", apply: VALIDATION)
   null: String @authorize(policy: "NULL", apply: AFTER_RESOLVER)
@@ -71,3 +71,21 @@ that can be used by the distributed GraphQL executor to resolve an entity by
 a stable key.
 """
 directive @lookup on FIELD_DEFINITION
+
+"""
+By default, only a single source schema is allowed to contribute
+a particular field to an object type.
+
+            
+This prevents source schemas from inadvertently defining similarly named
+fields that are not semantically equivalent.
+
+            
+Fields must be explicitly marked as @shareable to allow multiple source
+schemas to define them, ensuring that the decision to serve a field from
+more than one source schema is intentional and coordinated.
+
+
+directive @shareable repeatable on OBJECT | FIELD_DEFINITION
+"""
+directive @shareable repeatable on OBJECT | FIELD_DEFINITION

src/HotChocolate/Core/test/Types.Analyzers.Tests/__snapshots__/IntegrationTests.Schema.graphql

@@ -133,7 +133,7 @@ type PageInfo {
 
 type Query {
   "Fetches an object given its ID."
-  node("ID of the object." id: ID!): Node @lookup
+  node("ID of the object." id: ID!): Node @lookup @shareable
   "Lookup nodes by a list of IDs."
   nodes("The list of node IDs." ids: [ID!]!): [Node]!
   authors("Returns the first _n_ elements from the list." first: Int "Returns the elements in the list that come after the specified cursor." after: String "Returns the last _n_ elements from the list." last: Int "Returns the elements in the list that come before the specified cursor." before: String): AuthorsConnection

src/HotChocolate/Core/test/Types.Tests/Types/Relay/__snapshots__/NodeTypeTests.Infer_Node_From_Query_Field_Schema.snap

@@ -14,7 +14,7 @@ type Foo implements Node {
 
 type Query {
   "Fetches an object given its ID."
-  node("ID of the object." id: ID!): Node @lookup
+  node("ID of the object." id: ID!): Node @lookup @shareable
   "Lookup nodes by a list of IDs."
   nodes("The list of node IDs." ids: [ID!]!): [Node]!
   fooById(id: ID!): Foo!
@@ -26,3 +26,21 @@ that can be used by the distributed GraphQL executor to resolve an entity by
 a stable key.
 """
 directive @lookup on FIELD_DEFINITION
+
+"""
+By default, only a single source schema is allowed to contribute
+a particular field to an object type.
+
+            
+This prevents source schemas from inadvertently defining similarly named
+fields that are not semantically equivalent.
+
+            
+Fields must be explicitly marked as @shareable to allow multiple source
+schemas to define them, ensuring that the decision to serve a field from
+more than one source schema is intentional and coordinated.
+
+
+directive @shareable repeatable on OBJECT | FIELD_DEFINITION
+"""
+directive @shareable repeatable on OBJECT | FIELD_DEFINITION