Always dispose processes on FindExecutableProcess finalizer

neon-nyan · neon-nyan · commit 97a9880aa514 · 2025-08-19T02:36:53.000+07:00
diff --git a/Hi3Helper.Plugin.HBR/Exports.GameLaunch.cs b/Hi3Helper.Plugin.HBR/Exports.GameLaunch.cs
@@ -111,17 +111,17 @@ public override bool KillRunningGameCore(GameManagerExtension.RunGameFromGameMan
             }
         }
 
-        if (returnProcess == null)
+        try
         {
-            return null;
+            return returnProcess;
         }
-
-        foreach (var process in processes.Where(x => x != returnProcess))
+        finally
         {
-            process.Dispose();
+            foreach (var process in processes.Where(x => x != returnProcess))
+            {
+                process.Dispose();
+            }
         }
-
-        return returnProcess;
     }
 
     private static bool TryGetGameExecutablePath(GameManagerExtension.RunGameFromGameManagerContext context, [NotNullWhen(true)] out string? gameExecutablePath)

Original file line number	Diff line number	Diff line change
`@@ -111,17 +111,17 @@ public override bool KillRunningGameCore(GameManagerExtension.RunGameFromGameMan`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`
`114`		`- if (returnProcess == null)`
	`114`	`+ try`
`115`	`115`	`{`
`116`		`- return null;`
	`116`	`+ return returnProcess;`
`117`	`117`	`}`
`118`		`-`
`119`		`- foreach (var process in processes.Where(x => x != returnProcess))`
	`118`	`+ finally`
`120`	`119`	`{`
`121`		`- process.Dispose();`
	`120`	`+ foreach (var process in processes.Where(x => x != returnProcess))`
	`121`	`+ {`
	`122`	`+ process.Dispose();`
	`123`	`+ }`
`122`	`124`	`}`
`123`		`-`
`124`		`- return returnProcess;`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`private static bool TryGetGameExecutablePath(GameManagerExtension.RunGameFromGameManagerContext context, [NotNullWhen(true)] out string? gameExecutablePath)`