-
Notifications
You must be signed in to change notification settings - Fork 406
Drag vuenodes input #6514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Drag vuenodes input #6514
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e216883
[feat] add drag-and-drop support for VueNodes upload widgets
Myestery 228c62c
[fix] ensure Vue reactivity for batch upload array values
Myestery fab203b
[fix] manually trigger audio widget callback for VueNodes updates
Myestery 339a4b3
[fix] force Vue reactivity with nextTick node data refresh
Myestery 31dc5f5
[fix] pass getter function to useWidgetValue for proper reactivity
Myestery 7e73183
[fix] support getter functions for reactive modelValue tracking
Myestery 15a180f
Merge branch 'main' into drag-vuenodes-input
Myestery 4a2b30c
Fix code according to reviews
Myestery 2d9b5b3
remove extraneous forced update
Myestery d660fc6
remove extraneous state management hack
Myestery e60fa7b
fix failing tests
Myestery 953489c
use useMouseInElement from vue use
Myestery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does
useMouseInElementwork? What are the performance tradeoffs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No much perf gains,
The composable helps us know when the dragged file is within the node or not
@DrJKL suggests we should adopt the composable for checks like these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of using Pragmatic Drag and Drop instead of re-implementing it in this one component.