Fixed more lint errors. There are some lint errors hat i just cant fix, like line length in some log statements, and too many args

Author: pikachu0542

conditional/blueprints/attendance.py

@@ -425,9 +425,9 @@ def get_seminar_attendees(meeting_id):
                    TechnicalSeminar.approved == False).all()] # pylint: disable=singleton-comparison
     all_meetings = sorted((all_cm + all_ts), key=lambda k: k['dt_obj'], reverse=True)[offset:limit]
     if len(all_cm) % 10 != 0:
-        total_pages = (int(len(all_cm) / 10) + 1)
+        total_pages = int(len(all_cm) / 10) + 1
     else:
-        total_pages = (int(len(all_cm) / 10))
+        total_pages = int(len(all_cm) / 10)
     return render_template('attendance_history.html',
                            username=user_dict['username'],
                            history=all_meetings,

conditional/blueprints/dashboard.py

@@ -38,7 +38,7 @@ def display_dashboard(user_dict=None):
     # Get the list of voting members.
     can_vote = get_voting_members()
 
-    data = dict()
+    data = {}
     data['username'] = user_dict['account'].uid
     data['active'] = ldap_is_active(user_dict['account'])
     data['bad_standing'] = ldap_is_bad_standing(user_dict['account'])
@@ -71,7 +71,7 @@ def display_dashboard(user_dict=None):
 
     # only show housing if member has onfloor status
     if ldap_is_onfloor(user_dict['account']):
-        housing = dict()
+        housing = {}
         housing['points'] = user_dict['account'].housingPoints
         housing['room'] = user_dict['account'].roomNumber
         housing['queue_pos'] = get_queue_position(user_dict['account'].uid)

conditional/blueprints/major_project_submission.py

@@ -3,7 +3,6 @@
 
 import requests
 import boto3
-from botocore.exceptions import ClientError
 
 from flask import Blueprint
 from flask import request
@@ -185,4 +184,4 @@ def major_project_delete(pid, user_dict=None):
     return "Must be project owner to delete!", 401
 
 def send_slack_ping(payload):
-    requests.post(app.config['WEBHOOK_URL'], json.dumps(payload))
+    requests.post(app.config['WEBHOOK_URL'], json.dumps(payload), timeout=120)

conditional/blueprints/member_management.py

@@ -413,7 +413,7 @@ def member_management_deleteuser(fid, user_dict=None):
     if not fid.isdigit():
         return "can only delete freshman accounts", 400
 
-    log.info('backend', action="delete freshman account %s" % fid)
+    log.info('backend', action=f"delete freshman account {fid}")
 
     for fca in FreshmanCommitteeAttendance.query.filter(FreshmanCommitteeAttendance.fid == fid):
         db.session.delete(fca)

conditional/util/context_processors.py

@@ -33,7 +33,9 @@ def check_current_student(username):
 
 @app.context_processor
 def utility_processor():
-    return dict(
-        get_csh_name=get_csh_name, get_freshman_name=get_freshman_name, get_member_name=get_member_name,
-        check_current_student=check_current_student
-    )
+    return {
+            "get_csh_name": get_csh_name,
+            "get_freshman_name": get_freshman_name,
+            "get_member_name": get_member_name,
+            "check_current_student": check_current_student
+            }