Skip to content

[Enhancement] Allow lpConduit to be set on liquidity mint/burn actions #24

@cronii

Description

@cronii

Expected Behavior

An optional value lpConduit can be passed in the CrocLpOpts opts param of LP functions (mintAmbient, mintConc, burnAmbient, etc.). lpConduit is already a defined parameter at the smart contract level, but functionality is not exposed to the SDK.

Actual Behavior

Currently, lpConduit is hardcoded as AddressZero prior to encoding, so an LP conduit contract address can never be utilized.

Steps to Reproduce the Problem

  1. await croc.poolEth(USDC).mintAmbientQuote(50, [0.0001, 0.001], { lpConduit: SOME_LP_CONDUIT_ADDRESS })
  2. Check if USDC/ETH LP tokens are minted and sent to caller address

Specifications

  • Version: v0.2.75
  • Platform:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions