Decorate methods that shouldn't be invoked with [InternalForTesting]

Author: andrewlock

tracer/src/Datadog.Trace/Configuration/ConfigurationSources/NameValueConfigurationSource.cs

@@ -21,7 +21,7 @@ internal class NameValueConfigurationSource : StringConfigurationSource
     {
         private readonly NameValueCollection _nameValueCollection;
 
-        // Internal for testing only
+        [InternalForTesting]
         public NameValueConfigurationSource(NameValueCollection nameValueCollection)
             : this(nameValueCollection, ConfigurationOrigins.Code)
         {

tracer/src/Datadog.Trace/Configuration/ConfigurationSources/Telemetry/ConfigurationTelemetry.cs

@@ -71,7 +71,6 @@ public void Record(string key, int? value, ConfigurationOrigins origin, Telemetr
 
     public class ConfigurationTelemetryEntry
     {
-        // internal for testing
         private ConfigurationTelemetryEntry(string key, ConfigurationOrigins origin, ConfigurationTelemetryEntryType type, TelemetryErrorCode? error, string? stringValue = null, bool? boolValue = null, int? intValue = null, double? doubleValue = null)
         {
             Key = key;

tracer/src/Datadog.Trace/Configuration/ExporterSettings.cs

@@ -48,13 +48,13 @@ public partial class ExporterSettings
         internal const string DefaultMetricsUnixDomainSocket = "/var/run/datadog/dsd.socket";
         internal const string UdpPrefix = "udp://";
 
-        // Internal for testing only
+        [InternalForTesting]
         internal ExporterSettings()
             : this(source: null, new ConfigurationTelemetry())
         {
         }
 
-        // Internal for testing only
+        [InternalForTesting]
         internal ExporterSettings(IConfigurationSource? source)
             : this(source, File.Exists, new ConfigurationTelemetry())
         {
@@ -205,7 +205,7 @@ internal ExporterSettings(Raw rawSettings, Func<string, bool> fileExists, IConfi
 
         internal Raw RawSettings { get; }
 
-        // internal for testing
+        [InternalForTesting]
         internal static ExporterSettings Create(Dictionary<string, object?> settings)
             => new(new DictionaryConfigurationSource(settings.ToDictionary(x => x.Key, x => x.Value?.ToString()!)), new ConfigurationTelemetry());
 

tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

@@ -38,13 +38,13 @@ public record TracerSettings
         private readonly IConfigurationTelemetry _telemetry;
         private readonly Lazy<string> _fallbackApplicationName;
 
-        // Internal for testing
+        [InternalForTesting]
         internal TracerSettings()
             : this(null, new ConfigurationTelemetry(), new OverrideErrorLog())
         {
         }
 
-        // Internal for testing
+        [InternalForTesting]
         internal TracerSettings(IConfigurationSource? source)
         : this(source, new ConfigurationTelemetry(), new OverrideErrorLog())
         {

tracer/src/Datadog.Trace/ContinuousProfiler/ProfilerAvailabilityHelper.cs

@@ -6,6 +6,7 @@
 #nullable enable
 
 using System;
+using Datadog.Trace.SourceGenerators;
 using Datadog.Trace.Util;
 
 namespace Datadog.Trace.ContinuousProfiler;
@@ -25,7 +26,7 @@ internal static class ProfilerAvailabilityHelper
     /// </summary>
     public static bool IsContinuousProfilerAvailable => ProfilerIsAvailable.Value;
 
-    // Internal for testing
+    [InternalForTesting]
     internal static bool IsContinuousProfilerAvailable_TestingOnly(Func<bool> isClrProfilerAttached)
         => GetIsContinuousProfilerAvailable(isClrProfilerAttached);
 

tracer/src/Datadog.Trace/ContinuousProfiler/ProfilerSettings.cs

@@ -8,6 +8,7 @@
 using Datadog.Trace.Configuration;
 using Datadog.Trace.Configuration.ConfigurationSources.Telemetry;
 using Datadog.Trace.Configuration.Telemetry;
+using Datadog.Trace.SourceGenerators;
 
 namespace Datadog.Trace.ContinuousProfiler;
 
@@ -68,7 +69,7 @@ _ when x.ToBoolean() is { } boolean => boolean ? "true" : "false",
         };
     }
 
-    // Internal for testing only
+    [InternalForTesting]
     internal ProfilerSettings(ProfilerState state)
     {
         ProfilerState = state;

tracer/src/Datadog.Trace/SpanContext.cs

@@ -63,12 +63,12 @@ public partial class SpanContext : ISpanContext, IReadOnlyDictionary<string, str
         /// Initializes a new instance of the <see cref="SpanContext"/> class
         /// from a propagated context. <see cref="Parent"/> will be null
         /// since this is a root context locally.
-        /// Internal for testing
         /// </summary>
         /// <param name="traceId">The propagated trace id.</param>
         /// <param name="spanId">The propagated span id.</param>
         /// <param name="samplingPriority">The propagated sampling priority.</param>
         /// <param name="serviceName">The service name to propagate to child spans.</param>
+        [InternalForTesting]
         public SpanContext(ulong? traceId, ulong spanId, SamplingPriority? samplingPriority = null, string serviceName = null)
             : this((TraceId)(traceId ?? 0), serviceName)
         {

tracer/src/Datadog.Trace/TracerManager.cs

@@ -28,6 +28,7 @@
 using Datadog.Trace.RemoteConfigurationManagement;
 using Datadog.Trace.RuntimeMetrics;
 using Datadog.Trace.Sampling;
+using Datadog.Trace.SourceGenerators;
 using Datadog.Trace.Telemetry;
 using Datadog.Trace.Util.Http;
 using Datadog.Trace.Vendors.Newtonsoft.Json;
@@ -225,6 +226,7 @@ internal void Start()
         /// Run all the shutdown tasks for a standalone <see cref="TracerManager"/> instance,
         /// stopping the background processes.
         /// </summary>
+        [InternalForTesting]
         internal Task ShutdownAsync() => RunShutdownTasksAsync(this, null);
 
         private static async Task CleanUpOldTracerManager(TracerManager oldManager, TracerManager newManager)

tracer/src/Datadog.Trace/Util/BoundedConcurrentQueue.cs

@@ -22,6 +22,7 @@
 using System.Collections.Concurrent;
 using System.Diagnostics.CodeAnalysis;
 using System.Threading;
+using Datadog.Trace.SourceGenerators;
 
 namespace Datadog.Trace.Util
 {
@@ -42,7 +43,7 @@ public BoundedConcurrentQueue(int queueLimit)
             _queueLimit = queueLimit;
         }
 
-        // Internal for testing
+        [InternalForTesting]
         internal ConcurrentQueue<T> InnerQueue => _queue;
 
         public int Count => _counter;

tracer/src/Datadog.Trace/Util/ProcessHelpers.cs

@@ -14,6 +14,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Datadog.Trace.Logging;
+using Datadog.Trace.SourceGenerators;
 
 namespace Datadog.Trace.Util
 {
@@ -196,6 +197,7 @@ internal static IEnumerable<string> ParseWhereisOutput(string output)
         /// <summary>
         /// Internal for testing to make it easier to call using reflection from a sample app
         /// </summary>
+        [InternalForTesting]
         internal static void TestingOnly_RunCommand(string cmd, string? args)
         {
             RunCommand(new Command(cmd, args));