Add a nil check to func (s *Span) AddEvent #3644
              
  
  Closed
              
          
                  
                    
                      heitoriha
                    
                  
                
                  started this conversation in
                Feature Request
              
            Replies: 2 comments 2 replies
-
| 
         Sounds reasonable. Would you be interested in sending a PR for this?  | 
  
Beta Was this translation helpful? Give feedback.
                  
                    2 replies
                  
                
            -
| 
         Merged. It'll be released in our next   | 
  
Beta Was this translation helpful? Give feedback.
                  
                    0 replies
                  
                
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
-
Package Name
No response
Package Version(s)
No response
Describe the feature you'd like
Most of the exported functions of the type Span, in the tracer package, have a nil check in the receiver
That works very nicely when the the tracer has not started
So the end result is a noop
The function AddEvent is the only expcetion, can we consider adding an nil check to it?
Is your feature request related to a problem?
No response
Describe alternatives you've considered
For now I'm just doing the nil check in my own code before calling span.AddEvent
Additional context
No response
Beta Was this translation helpful? Give feedback.
All reactions