Implement ProfileType.UnmarshalText method #3872
              
  
  Closed
              
          
                  
                    
                      crdueck
                    
                  
                
                  started this conversation in
                Feature Request
              
            Replies: 2 comments 1 reply
-
| 
         To be clear, is your intended use case to take profile types from some textual config source and unmarshal them such that they can be passed to   | 
  
Beta Was this translation helpful? Give feedback.
                  
                    1 reply
                  
                
            -
| 
         Closing this after merging #3881. Thanks for your contribution @crdueck!  | 
  
Beta Was this translation helpful? Give feedback.
                  
                    0 replies
                  
                
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Package Name
profiler
Package Version(s)
No response
Describe the feature you'd like
Proposal to implement
ProfileType.UnmarshalTextmethod to satisfy the TextUnmarshaler interface. This supports configuration use cases where the profile type is parsed from text source, such as environment variables or config file.This is purely a convenience since library users can just define their own wrapper type and implement the method, but it requires additional wrapping and unwrapping. So I would understand if this proposal was rejected since it doesn't necessarily have to be implemented in
dd-trace-go.I am willing to contribute a PR if this issue is approved.
Is your feature request related to a problem?
No response
Describe alternatives you've considered
No response
Additional context
No response
Beta Was this translation helpful? Give feedback.
All reactions