remove pycache directory during upgrades (#871)

* remove pycache directory during upgrades

This PR removes /opt/datadog-agent/python-scripts/__pycache__ similarly to other installation methods.

* Remove un-necessary recurse and lint

---------

Co-authored-by: Timothée Bavelier <[email protected]>
Co-authored-by: Fanny Jiang <[email protected]>

Author: 3 people

manifests/init.pp

@@ -441,6 +441,14 @@
 
   # Install agent
   if $manage_install {
+    # Ensure legacy Python bytecode cache directory is removed before Agent package installation (Linux only)
+    if ($facts['os']['name'] != 'Windows' and $facts['os']['family'] != 'Darwin') {
+      file { '/opt/datadog-agent/python-scripts/__pycache__':
+        ensure => absent,
+        force  => true,
+        before => Package[$agent_flavor],
+      }
+    }
     case $facts['os']['name'] {
       'Ubuntu','Debian','Raspbian' : {
         if $use_apt_backup_keyserver != undef or $apt_backup_keyserver != undef or $apt_keyserver != undef {