fix LongsColumnWithNulls and FloatsColumnWithNulls to override isNull in order to actually use nullValueBitmap (apache#5510)

clintropolis · jihoonson · commit 885b975c9574 · 2018-03-20T16:04:08.000-07:00
diff --git a/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java b/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java
@@ -44,6 +44,12 @@ public ColumnValueSelector makeColumnValueSelector(ReadableOffset offset)
     return column.makeColumnValueSelector(offset, nullValueBitmap);
   }
 
+  @Override
+  public boolean isNull(int rowNum)
+  {
+    return nullValueBitmap.get(rowNum);
+  }
+
   @Override
   public void inspectRuntimeShape(RuntimeShapeInspector inspector)
   {
diff --git a/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java b/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java
@@ -44,6 +44,12 @@ public ColumnValueSelector makeColumnValueSelector(ReadableOffset offset)
     return column.makeColumnValueSelector(offset, nullValueBitmap);
   }
 
+  @Override
+  public boolean isNull(int rowNum)
+  {
+    return nullValueBitmap.get(rowNum);
+  }
+
   @Override
   public void inspectRuntimeShape(RuntimeShapeInspector inspector)
   {

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,12 @@ public ColumnValueSelector makeColumnValueSelector(ReadableOffset offset)`
`44`	`44`	`return column.makeColumnValueSelector(offset, nullValueBitmap);`
`45`	`45`	`}`
`46`	`46`
	`47`	`+ @Override`
	`48`	`+ public boolean isNull(int rowNum)`
	`49`	`+ {`
	`50`	`+ return nullValueBitmap.get(rowNum);`
	`51`	`+ }`
	`52`	`+`
`47`	`53`	`@Override`
`48`	`54`	`public void inspectRuntimeShape(RuntimeShapeInspector inspector)`
`49`	`55`	`{`