Improve template

Author: oorestisime

debsources/app/copyright/templates/copyright/value_error.html

@@ -11,6 +11,6 @@
 <h2>{{ self.title() }}</h2>
 <p>Parsing The debian/copyright file yields a Value error. The error is {{error}}
 
-<a href="{{ url_for('sources.source', path_to=(package +'/'+version+'/debian/copyright'))}}">View raw copyright file</a>
+<p><a href="{{ url_for('sources.source', path_to=(package +'/'+version+'/debian/copyright'))}}">View raw copyright file</a></p>
 </p> 
 {% endblock %}

debsources/app/copyright/views.py

@@ -80,11 +80,11 @@ def get_objects(self, path_to):
                         version=version,
                         dump='False',
                         header=helper.get_copyright_header(c),
-                        files=helper.parse_copyright_paragraphs_for_html_render(
+                        files=helper.parse_copyright_paragraphs_html_render(
                             c, "/src/" + package + "/" + version + "/"),
                         licenses=helper.parse_licenses_for_html_render(c))
         except ValueError as e:
-            raise CopyrightValueError(package, version, e)
+            raise CopyrightValueError(package, version, str(e))
 
 
 class ChecksumLicenseView(ChecksumView):

debsources/license_helper.py

@@ -149,7 +149,7 @@ def get_copyright_header(copyright):
     return copyright.header._RestrictedWrapper__data
 
 
-def parse_copyright_paragraphs_for_html_render(copyright, base_url):
+def parse_copyright_paragraphs_html_render(copyright, base_url):
     """ Returns list of File objects. If `base_url` is provided
         then it creates links to base_url+glob
     """
@@ -179,13 +179,10 @@ def parse_licenses_for_html_render(copyright):
     """
     licenses = []
     for par in copyright.all_license_paragraphs():
-        try:
-            licenses.append({'synopsis': par.license.synopsis,
-                             'link': match_license(par.license.synopsis),
-                             'text': par.license.text,
-                             'comment': par.comment})
-        except ValueError:
-            raise ValueError
+        licenses.append({'synopsis': par.license.synopsis,
+                         'link': match_license(par.license.synopsis),
+                         'text': par.license.text,
+                         'comment': par.comment})
     return licenses