wire: update to slight spec neating.

Signed-off-by: Rusty Russell <[email protected]>

Author: rustyrussell

plugins/fetchinvoice.c

@@ -723,8 +723,8 @@ static struct command_result *invreq_done(struct command *cmd,
 
 		/* BOLT-recurrence #12:
 		 * - if `offer_recurrence_limit` is present:
-		 *   - MUST NOT send an `invoice_request` for a period greater than
-		 *     `max_period`
+		 *   - MUST NOT send an `invoice_request` for a period index greater than
+		 *     `max_period_index`
 		 */
 		if (sent->invreq->offer_recurrence_limit
 		    && period_idx > *sent->invreq->offer_recurrence_limit)

plugins/offers_invreq_hook.c

@@ -442,7 +442,7 @@ static struct command_result *check_period(struct command *cmd,
 	/* BOLT-recurrence #12:
 	 * - if `offer_recurrence_limit` is present:
 	 *   - MUST reject the invoice request if the period index is greater than
-	 *     `max_period`.
+	 *     `max_period_index`.
 	 */
 	if (ir->invreq->offer_recurrence_limit
 	    && period_idx > *ir->invreq->offer_recurrence_limit) {

wire/bolt12_wire.csv

@@ -29,7 +29,7 @@ tlvdata,offer,offer_recurrence_base,recurrence_base,recurrence_base,
 tlvtype,offer,offer_recurrence_paywindow,1000000027
 tlvdata,offer,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 tlvtype,offer,offer_recurrence_limit,1000000029
-tlvdata,offer,offer_recurrence_limit,max_period,tu32,
+tlvdata,offer,offer_recurrence_limit,max_period_index,tu32,
 subtype,recurrence
 subtypedata,recurrence,time_unit,byte,
 subtypedata,recurrence,period,tu32,
@@ -72,7 +72,7 @@ tlvdata,invoice_request,offer_recurrence_base,recurrence_base,recurrence_base,
 tlvtype,invoice_request,offer_recurrence_paywindow,1000000027
 tlvdata,invoice_request,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 tlvtype,invoice_request,offer_recurrence_limit,1000000029
-tlvdata,invoice_request,offer_recurrence_limit,max_period,tu32,
+tlvdata,invoice_request,offer_recurrence_limit,max_period_index,tu32,
 tlvtype,invoice_request,invreq_chain,80
 tlvdata,invoice_request,invreq_chain,chain,chain_hash,
 tlvtype,invoice_request,invreq_amount,82
@@ -134,7 +134,7 @@ tlvdata,invoice,offer_recurrence_base,recurrence_base,recurrence_base,
 tlvtype,invoice,offer_recurrence_paywindow,1000000027
 tlvdata,invoice,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 tlvtype,invoice,offer_recurrence_limit,1000000029
-tlvdata,invoice,offer_recurrence_limit,max_period,tu32,
+tlvdata,invoice,offer_recurrence_limit,max_period_index,tu32,
 tlvtype,invoice,invreq_chain,80
 tlvdata,invoice,invreq_chain,chain,chain_hash,
 tlvtype,invoice,invreq_amount,82

wire/extracted_bolt12_01_recurrence.patch

@@ -13,7 +13,7 @@
 +tlvtype,offer,offer_recurrence_paywindow,1000000027
 +tlvdata,offer,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 +tlvtype,offer,offer_recurrence_limit,1000000029
-+tlvdata,offer,offer_recurrence_limit,max_period,tu32,
++tlvdata,offer,offer_recurrence_limit,max_period_index,tu32,
 +subtype,recurrence
 +subtypedata,recurrence,time_unit,byte,
 +subtypedata,recurrence,period,tu32,
@@ -39,7 +39,7 @@
 +tlvtype,invoice_request,offer_recurrence_paywindow,1000000027
 +tlvdata,invoice_request,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 +tlvtype,invoice_request,offer_recurrence_limit,1000000029
-+tlvdata,invoice_request,offer_recurrence_limit,max_period,tu32,
++tlvdata,invoice_request,offer_recurrence_limit,max_period_index,tu32,
  tlvtype,invoice_request,invreq_chain,80
  tlvdata,invoice_request,invreq_chain,chain,chain_hash,
  tlvtype,invoice_request,invreq_amount,82
@@ -80,7 +80,7 @@
 +tlvtype,invoice,offer_recurrence_paywindow,1000000027
 +tlvdata,invoice,offer_recurrence_paywindow,recurrence_paywindow,recurrence_paywindow,
 +tlvtype,invoice,offer_recurrence_limit,1000000029
-+tlvdata,invoice,offer_recurrence_limit,max_period,tu32,
++tlvdata,invoice,offer_recurrence_limit,max_period_index,tu32,
  tlvtype,invoice,invreq_chain,80
  tlvdata,invoice,invreq_chain,chain,chain_hash,
  tlvtype,invoice,invreq_amount,82