issue 434 - handle setTimeout on object which is not window or $window

Alex Shnayder · Alex Shnayder · commit 39d7da7cc71d · 2017-01-15T14:01:17.000+02:00
diff --git a/rules/timeout-service.js b/rules/timeout-service.js
@@ -24,8 +24,11 @@ module.exports = {
                     return;
                 }
 
-                if (node.object.type === 'Identifier' && (node.object.name === 'window' || node.object.name === '$window')) {
-                    context.report(node, message, {});
+                if (node.object.type === 'Identifier') {
+                    if ((node.object.name === 'window' || node.object.name === '$window')){
+                        context.report(node, message, {});
+                    }
+
                     return;
                 }
 
diff --git a/test/timeout-service.js b/test/timeout-service.js
@@ -20,7 +20,8 @@ eslintTester.run('timeout-service', rule, {
     valid: [
         '$timeout(function() {})',
         '$timeout(function() {}, 1000)',
-        '$timeout(function() {}, 1000, true)'
+        '$timeout(function() {}, 1000, true)',
+        'nonWindowObject.setTimeout(function() {})'
     ].concat(commonFalsePositives),
     invalid: [
         {code: 'window.setTimeout(function() {}, 1000)', errors: [{message: message}]},

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,11 @@ module.exports = {`
`24`	`24`	`return;`
`25`	`25`	`}`
`26`	`26`
`27`		`- if (node.object.type === 'Identifier' && (node.object.name === 'window' \|\| node.object.name === '$window')) {`
`28`		`- context.report(node, message, {});`
	`27`	`+ if (node.object.type === 'Identifier') {`
	`28`	`+ if ((node.object.name === 'window' \|\| node.object.name === '$window')){`
	`29`	`+ context.report(node, message, {});`
	`30`	`+ }`
	`31`	`+`
`29`	`32`	`return;`
`30`	`33`	`}`
`31`	`34`