Issue #60 Components name rules should not return error if the prefix is undefined

Author: EmmanuelDemey

rules/ng_controller_name.js

@@ -9,6 +9,11 @@ module.exports = function(context) {
         'CallExpression': function(node) {
 
             var prefix = context.options[0];
+
+            if(prefix === undefined) {
+                return;
+            }
+
             var callee = node.callee;
             if (callee.type === 'MemberExpression' && callee.property.name === 'controller') {
                 var name = node.arguments[0].value;

rules/ng_di.js

@@ -20,7 +20,7 @@ module.exports = function(context) {
             var callee = node.callee;
 
             if (callee.type === 'MemberExpression' && angularObjectList.indexOf(callee.property.name) >= 0) {
-              
+
                if(syntax === 'function' && (!utils.isFunctionType(node.arguments[1]) && !utils.isIdentifierType(node.arguments[1]))){
                   report(node, syntax);
                }

rules/ng_directive_name.js

@@ -9,6 +9,10 @@ module.exports = function(context) {
         'CallExpression': function(node) {
 
             var prefix = context.options[0];
+            if(prefix === undefined) {
+                return;
+            }
+
             var callee = node.callee;
             if (callee.type === 'MemberExpression' && callee.property.name === 'directive') {
                 var name = node.arguments[0].value;

rules/ng_filter_name.js

@@ -9,6 +9,10 @@ module.exports = function(context) {
         'CallExpression': function(node) {
 
             var prefix = context.options[0];
+            if(prefix === undefined) {
+                return;
+            }
+
             var callee = node.callee;
             if (callee.type === 'MemberExpression' && callee.property.name === 'filter') {
                 var name = node.arguments[0].value;

rules/ng_module_name.js

@@ -12,6 +12,10 @@ module.exports = function(context) {
         'CallExpression': function(node) {
 
             var prefix = context.options[0];
+            if(prefix === undefined) {
+                return;
+            }
+
             var callee = node.callee;
             if (callee.type === 'MemberExpression' && callee.property.name === 'module' && isArray(node.arguments[1])) {
                var name = node.arguments[0].value;

rules/ng_no_digest.js

@@ -5,7 +5,7 @@ module.exports = function(context) {
     return {
 
         'CallExpression': function(node) {
-			if(node.callee.type ==='MemberExpression' &&  node.callee.property.type === 'Identifier' && node.callee.property.name === '$digest'){
+			if(node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === '$digest'){
                 context.report(node, 'Instead of using the $destroy method, you should prefer $apply()', {});
             }
         }

rules/ng_service_name.js

@@ -9,6 +9,10 @@ module.exports = function(context) {
         'CallExpression': function(node) {
 
             var prefix = context.options[0];
+            if(prefix === undefined) {
+                return;
+            }
+
             var callee = node.callee;
             if (callee.type === 'MemberExpression' &&
                 (callee.property.name === 'provider' || callee.property.name === 'service' || callee.property.name === 'factory' || callee.property.name === 'constant' || callee.property.name === 'value')) {

test/ng_controller_name.js

@@ -17,6 +17,9 @@ eslintTester.addRuleTest('rules/ng_controller_name', {
     }, {
         code: 'angular.controller("eslintController", function(){});',
         args: [1, /^eslint/]
+    }, {
+        code: 'angular.controller("eslintController", function(){});',
+        args: [1, undefined]
     }],
     invalid: [
         {

test/ng_directive_name.js

@@ -17,6 +17,9 @@ eslintTester.addRuleTest('rules/ng_directive_name', {
     }, {
         code: 'angular.directive("eslintDirective", function(){});',
         args: [1, /^eslint/]
+    }, {
+        code: 'angular.directive("eslintDirective", function(){});',
+        args: [1, undefined]
     }],
     invalid: [
         {

test/ng_filter_name.js

@@ -17,6 +17,9 @@ eslintTester.addRuleTest('rules/ng_filter_name', {
     }, {
         code: 'angular.filter("eslintFilter", function(){});',
         args: [1, /^eslint/]
+    }, {
+        code: 'angular.filter("eslintFilter", function(){});',
+        args: [1, undefined]
     }],
     invalid: [
         {