Skip to content

Commit f8d78c9

Browse files
author
Harini Subramanian
committed
Bgpd: Medium coverity changes - Null pointer dereferences
This commit addresses null pointer dereferences in bgpd folder alone. Signed-off-by: Harini Subramanian <[email protected]>
1 parent 52af40d commit f8d78c9

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

bgpd/bgp_rpki.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,6 +1700,8 @@ DEFPY (no_rpki,
17001700
}
17011701

17021702
rpki_vrf = find_rpki_vrf(vrfname);
1703+
if (!rpki_vrf)
1704+
return CMD_WARNING;
17031705

17041706
rpki_delete_all_cache_nodes(rpki_vrf);
17051707
stop(rpki_vrf);

bgpd/bgpd.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2802,13 +2802,14 @@ int peer_delete(struct peer *peer)
28022802
/* If this peer belongs to peer group, clear up the
28032803
relationship. */
28042804
if (peer->group) {
2805+
struct peer_group *group = peer->group;
2806+
28052807
if (peer_dynamic_neighbor(peer))
28062808
peer_drop_dynamic_neighbor(peer);
28072809

2808-
if ((pn = listnode_lookup(peer->group->peer, peer))) {
2809-
peer = peer_unlock(
2810-
peer); /* group->peer list reference */
2811-
list_delete_node(peer->group->peer, pn);
2810+
if ((pn = listnode_lookup(group->peer, peer))) {
2811+
list_delete_node(group->peer, pn);
2812+
peer_unlock(peer); /* group->peer list reference */
28122813
}
28132814
peer->group = NULL;
28142815
}

0 commit comments

Comments
 (0)