Bgpd: Medium coverity changes - Null pointer dereferences #19723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Oct 10, 2025
|
Please split into separate commits and write in the commits what Coverity issue is solved here. |
This commit addresses null pointer dereferences in bgpd folder. Description: 1) Added NULL checks wherever it is missed in bgpd. 2) For bgpd/bgpd.c , added comment for why the changes is done and its necessity. 3) Assert is added in one place for CID 19511 (bgp_packet.c) instead of silent NULL check. Signed-off-by: Harini Subramanian <[email protected]>
hnattamaisub
force-pushed
the
coverity_bgpd
branch
from
f8d78c9 to
c947bcb
Compare
|
Please split into separate commits (each coverity) and apply the slying too (see frrbot). |
|
Added new PR with single commit for each coverity as suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses null pointer dereferences in bgpd folder alone.