Skip to content

Conversation

JooHyukKim
Copy link
Member

No description provided.

@JooHyukKim JooHyukKim marked this pull request as draft August 3, 2025 14:06
@JooHyukKim
Copy link
Member Author

Trying to think how to minimize the amount of changes...

@cowtowncoder
Copy link
Member

Quick note: I think this should probably go in 2.21.x. Not a problem since I'll (eventually) branch 2.20 off of 2.x, just a note.
This because I hope to got 2.20.0-rc1 released next week, and this seems like potentially higher-risk change.

@JooHyukKim
Copy link
Member Author

Did some more refactor for code deduplication

@JooHyukKim JooHyukKim marked this pull request as ready for review September 6, 2025 18:35
@JooHyukKim
Copy link
Member Author

Should we keep this open?
Or any improvement suggestion welcome! @cowtowncoder

@cowtowncoder
Copy link
Member

@JooHyukKim yes let's keep it open. I have been (and am) too busy to consider it, with 3.0.0 work. But hope to get back in future.

@JooHyukKim
Copy link
Member Author

@cowtowncoder, yeah guessed so.
Lemme know if anything else I can help with the 3.0 prep.

@cowtowncoder
Copy link
Member

@JooHyukKim Thanks! Will do if there's anything. Hoping to actually push release today if all goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants