Merge pull request #14 from SpacePossum/master_tweaks

tweaks

Author: SpacePossum

.php_cs.dist

@@ -16,14 +16,18 @@ return Symfony\CS\Config\Config::create()
     ->level(Symfony\CS\FixerInterface::SYMFONY_LEVEL)
     // and extra fixers:
     ->fixers(array(
+        'combine_consecutive_unsets',
         'ereg_to_preg',
         'header_comment',
         'newline_after_open_tag',
+        'no_useless_else',
         'no_useless_return',
         'ordered_use',
+        'short_array_syntax',
+        'phpdoc_order',
         'php_unit_construct',
+        'php_unit_dedicate_assert',
         'php_unit_strict',
-        'short_array_syntax',
         'strict',
         'strict_param',
         '-empty_return',

src/Caching/Clients/MemcacheLoggingProxy.php

@@ -11,6 +11,7 @@
 
 namespace GeckoPackages\Silex\Services\Caching\Clients;
 
+use GeckoPackages\Silex\Services\Caching\NullStopWatch;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Stopwatch\Stopwatch;
 
@@ -95,6 +96,8 @@ public function getPrefix()
         if ($this->originalClient instanceof Memcached) {
             return $this->__call('getPrefix', []);
         }
+
+        return false;
     }
 
     /**
@@ -107,5 +110,7 @@ public function setPrefix($prefix)
         if ($this->originalClient instanceof Memcached) {
             return $this->__call('setPrefix', [$prefix]);
         }
+
+        return false;
     }
 }

src/Caching/Clients/NullStopWatch.php renamed to src/Caching/NullStopWatch.php

@@ -9,17 +9,15 @@
  * with this source code in the file LICENSE.
  */
 
-namespace GeckoPackages\Silex\Services\Caching\Clients;
+namespace GeckoPackages\Silex\Services\Caching;
 
 final class NullStopWatch
 {
     public function start($name, $category = null)
     {
-        //
     }
 
     public function stop($name)
     {
-        //
     }
 }

tests/Caching/Tests/TestLogger.php

@@ -48,7 +48,6 @@ public function debug($message, array $context = [])
      */
     public function error($message, array $context = [])
     {
-        $this->errorLog[] = [$message, $context];
     }
 
     /**