Merge pull request #21 from SpacePossum/3_0_deprecated

Deprecate flag not being bool.

Author: SpacePossum

src/Caching/MemcachedServiceProvider.php

@@ -70,6 +70,7 @@ public function register(Container $app)
                     }
 
                     $client = new $client();
+
                     break;
             }
 
@@ -109,7 +110,15 @@ public function register(Container $app)
      */
     private function getLogger(Container $app, $name)
     {
-        if (!isset($app[$name.'.enable_log']) || !interface_exists('Psr\Log\LoggerInterface')) {
+        if (!isset($app[$name.'.enable_log'])) {
+            return null;
+        }
+
+        if (!is_bool($app[$name.'.enable_log'])) {
+            @trigger_error(sprintf('Using a non-boolean value for \'%s.enable_log\' is deprecated and will be removed in v4.0.', $name), E_USER_DEPRECATED);
+        }
+
+        if (!interface_exists('Psr\Log\LoggerInterface')) {
             return null;
         }
 

tests/Caching/Tests/MemcachedServiceProviderTest.php

@@ -211,6 +211,19 @@ public function provideLoggerByConfiguration()
         ];
     }
 
+    /**
+     * @group legacy
+     */
+    public function testDeprecatedConfig()
+    {
+        $app = new Application();
+        $app->register(new MemcachedServiceProvider(), [
+            'memcache.enable_log' => null,
+            'memcache.client' => 'mock',
+        ]);
+        $app['memcache']->setPrefix('1');
+    }
+
     /**
      * @expectedException \UnexpectedValueException
      * @expectedExceptionMessageRegExp #^Cannot use string\#"\\Foo\\Bar" as class for memcache client.$#