`_rotate_log_file` breaks non-debug web exports

[rikmarais]

https://github.com/GodotModding/godot-mod-loader/blob/4.x-dev/addons/mod_loader/api/log.gd#L587 and https://github.com/GodotModding/godot-mod-loader/blob/4.x-dev/addons/mod_loader/setup/setup_log.gd#L178 assert when a log_file cannot be created but lack an early exit.

In non-debug web exports, the asserts are ignored and there is an obscure index out of bounds exception.

In a debug web export, the asserts appear in the browser console, but there's no index out of bounds exception.

I'm not sure why the log file can't be created in a web export or why it causes an exception in a non-debug export but not in a debug export, though.

Here is a minimal reproducible example project:
modloaderwebrelease.zip

[Qubus0]

Interesting, thanks for reporting. We haven't done a lot of testing in web games yet (see #471), so thank you for pioneering 😄 I would assume the native log rotation is just disabled in the web. Maybe even logging to file overall, because everything is just saved to indexedDB in the browser, which isn't particularly accessible for most users.
I think the simplest way forward is to just disable log rotation and stop writing to our own log file in web exports. The prints get passed to the browser console anyway

[rikmarais]

Thanks for checking out the issue!
I didn't see any docs indicating mod loader's status for web specifically, so that's good to know!

I did notice that an early return right after the assert in _rotate_log_file does prevent the crash, at least.

I imagine that on a desktop release build, if the log file fails to be created there's an exception. Adding an early return to _rotate_log_file on these lines 4.x-dev/addons/mod_loader/api/log.gd#L587 and 4.x-dev/addons/mod_loader/setup/setup_log.gd#L178 like the one in _write_to_log_file is probably a good idea, too :)