Skip to content

Commit 650e0f8

Browse files
committed
Remove readiness probe and health check from otel-agent sidecars
Remove the readiness probe and health check from otel-agent containers in reconciler, reconciler-manager, and resourcegroup controller to align container behavior. The healthcheck component can fail to bind to the port or respond under CPU throttling, causing unnecessary pod unready states even when the container is running. The otel-collector health check in the config-management-monitoring namespace is retained since it is tied to a Service.
1 parent f9b4977 commit 650e0f8

File tree

6 files changed

+0
-50
lines changed

6 files changed

+0
-50
lines changed

manifests/otel-agent-cm.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ data:
3939
batch:
4040
resourcedetection:
4141
detectors: [env, gcp]
42-
extensions:
43-
health_check:
44-
endpoint: 0.0.0.0:13133
4542
service:
46-
extensions: [health_check]
4743
pipelines:
4844
metrics:
4945
receivers: [opencensus]

manifests/otel-agent-reconciler-cm.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,7 @@ data:
5959
# the GCE metadata service, if available.
6060
resourcedetection:
6161
detectors: [env, gcp]
62-
extensions:
63-
health_check:
64-
endpoint: 0.0.0.0:13133
6562
service:
66-
extensions: [health_check]
6763
pipelines:
6864
metrics:
6965
receivers: [opencensus]

manifests/templates/reconciler-manager-configmap.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,6 @@ data:
195195
volumeMounts:
196196
- name: otel-agent-config-reconciler-vol
197197
mountPath: /conf
198-
readinessProbe:
199-
httpGet:
200-
path: /
201-
port: 13133 # Health Check extension default port.
202-
scheme: HTTP
203198
imagePullPolicy: IfNotPresent
204199
# These KUBE env vars help populate OTEL_RESOURCE_ATTRIBUTES which
205200
# is used by the otel-agent to populate resource attributes when

manifests/templates/reconciler-manager.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,6 @@ spec:
9191
volumeMounts:
9292
- name: otel-agent-config-vol
9393
mountPath: /conf
94-
readinessProbe:
95-
httpGet:
96-
path: /
97-
port: 13133 # Health Check extension default port.
9894
# These KUBE env vars help populate OTEL_RESOURCE_ATTRIBUTES which
9995
# is used by the otel-agent to populate resource attributes when
10096
# emiting metrics to the otel-collector. This is more efficient than

manifests/templates/resourcegroup-manifest.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,7 @@ data:
167167
# the GCE metadata service, if available.
168168
resourcedetection:
169169
detectors: [env, gcp]
170-
extensions:
171-
health_check:
172-
endpoint: 0.0.0.0:13133
173170
service:
174-
extensions: [health_check]
175171
pipelines:
176172
metrics:
177173
receivers: [opencensus]
@@ -275,10 +271,6 @@ spec:
275271
- containerPort: 55678
276272
- containerPort: 8888
277273
- containerPort: 13133
278-
readinessProbe:
279-
httpGet:
280-
path: /
281-
port: 13133
282274
resources:
283275
requests:
284276
cpu: 10m

test/kustomization/expected.yaml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -5650,11 +5650,7 @@ data:
56505650
batch:
56515651
resourcedetection:
56525652
detectors: [env, gcp]
5653-
extensions:
5654-
health_check:
5655-
endpoint: 0.0.0.0:13133
56565653
service:
5657-
extensions: [health_check]
56585654
pipelines:
56595655
metrics:
56605656
receivers: [opencensus]
@@ -5708,11 +5704,7 @@ data:
57085704
# the GCE metadata service, if available.
57095705
resourcedetection:
57105706
detectors: [env, gcp]
5711-
extensions:
5712-
health_check:
5713-
endpoint: 0.0.0.0:13133
57145707
service:
5715-
extensions: [health_check]
57165708
pipelines:
57175709
metrics:
57185710
receivers: [opencensus]
@@ -5907,11 +5899,6 @@ data:
59075899
volumeMounts:
59085900
- name: otel-agent-config-reconciler-vol
59095901
mountPath: /conf
5910-
readinessProbe:
5911-
httpGet:
5912-
path: /
5913-
port: 13133 # Health Check extension default port.
5914-
scheme: HTTP
59155902
imagePullPolicy: IfNotPresent
59165903
# These KUBE env vars help populate OTEL_RESOURCE_ATTRIBUTES which
59175904
# is used by the otel-agent to populate resource attributes when
@@ -6034,11 +6021,7 @@ data:
60346021
# the GCE metadata service, if available.
60356022
resourcedetection:
60366023
detectors: [env, gcp]
6037-
extensions:
6038-
health_check:
6039-
endpoint: 0.0.0.0:13133
60406024
service:
6041-
extensions: [health_check]
60426025
pipelines:
60436026
metrics:
60446027
receivers: [opencensus]
@@ -6370,10 +6353,6 @@ spec:
63706353
- containerPort: 55678
63716354
- containerPort: 8888
63726355
- containerPort: 13133
6373-
readinessProbe:
6374-
httpGet:
6375-
path: /
6376-
port: 13133
63776356
resources:
63786357
limits:
63796358
cpu: 1
@@ -6494,10 +6473,6 @@ spec:
64946473
- containerPort: 55678
64956474
- containerPort: 8888
64966475
- containerPort: 13133
6497-
readinessProbe:
6498-
httpGet:
6499-
path: /
6500-
port: 13133
65016476
resources:
65026477
requests:
65036478
cpu: 10m

0 commit comments

Comments
 (0)