Skip to content

Commit 064151d

Browse files
authored
Merge pull request #108 from IBM/akash
Changing image building
2 parents a634849 + 8e7d5d4 commit 064151d

File tree

5 files changed

+73
-13
lines changed

5 files changed

+73
-13
lines changed

block-storage-attacher/Dockerfile.builder

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
FROM golang:1.15.2
22

3+
ARG GOPROXY=off
4+
35
WORKDIR /go/src/github.com/IBM/ibmcloud-storage-utilities/block-storage-attacher
46
ADD . /go/src/github.com/IBM/ibmcloud-storage-utilities/block-storage-attacher
57
RUN set -ex; cd /go/src/github.com/IBM/ibmcloud-storage-utilities/block-storage-attacher/ && \

block-storage-attacher/Makefile

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ deps:
2626
# glide install --strip-vendor
2727
go get github.com/pierrre/gotestcover
2828
go get -v github.com/securego/gosec/cmd/gosec
29+
go get github.ibm.com/alchemy-containers/[email protected]
2930

3031
.PHONY: fmt
3132
fmt:
@@ -54,20 +55,23 @@ coverage:
5455

5556
.PHONY: buildimage
5657
buildimage: build-systemutil
57-
docker build \
58-
--build-arg git_commit_id=${GIT_COMMIT_SHA} \
59-
--build-arg git_remote_url=${GIT_REMOTE_URL} \
60-
--build-arg build_date=${BUILD_DATE} \
61-
--build-arg travis_build_number=${TRAVIS_BUILD_NUMBER} \
62-
--build-arg REPO_SOURCE_URL=${REPO_SOURCE_URL} \
63-
--build-arg BUILD_URL=${BUILD_URL} \
64-
-t $(IMAGE):$(VERSION) -f Dockerfile .
58+
go run github.ibm.com/alchemy-containers/go-build-tools/cmd/goproxy -docker-build -- \
59+
docker build \
60+
--build-arg git_commit_id=${GIT_COMMIT_SHA} \
61+
--build-arg git_remote_url=${GIT_REMOTE_URL} \
62+
--build-arg build_date=${BUILD_DATE} \
63+
--build-arg travis_build_number=${TRAVIS_BUILD_NUMBER} \
64+
--build-arg REPO_SOURCE_URL=${REPO_SOURCE_URL} \
65+
--build-arg BUILD_URL=${BUILD_URL} \
66+
-t $(IMAGE):$(VERSION) -f Dockerfile .
6567

6668

6769
.PHONY: build-systemutil
6870
build-systemutil:
6971
#Build executables like block-attacher and system util GO binaries
70-
docker build -t common-lib-builder --pull -f Dockerfile.builder .
72+
go mod download
73+
go run github.ibm.com/alchemy-containers/go-build-tools/cmd/goproxy -docker-build -- \
74+
docker build -t common-lib-builder --pull -f Dockerfile.builder .
7175
docker run common-lib-builder /bin/true
7276
docker cp `docker ps -q -n=1`:/go/bin/systemutil ./systemutil
7377
docker cp `docker ps -q -n=1`:/go/bin/block-storage-attacher ./block-storage-attacher

block-storage-attacher/OPENSOURCE

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,16 @@ https://hub.docker.com/_/wcp-alchemy-containers-team-access-redhat-docker-remote
22
github.com/BurntSushi/toml,v0.3.1
33
github.com/blang/semver,v3.5.1+incompatible
44
github.com/coreos/go-systemd/v22,v22.1.0
5-
github.com/onsi/ginkgo,v1.11.0
6-
github.com/onsi/gomega,v1.7.0
5+
github.com/onsi/ginkgo,v1.12.0
6+
github.com/onsi/gomega,v1.9.0
77
github.com/opencontainers/selinux,v1.6.0
8+
github.com/pierrre/gotestcover,v0.0.0-20160517101806-924dca7d15f0
89
github.com/satori/go.uuid,v1.2.0
10+
github.com/securego/gosec,v0.0.0-20200401082031-e946c8c39989
911
github.com/spf13/viper,v1.7.1
1012
github.com/stretchr/testify,v1.4.0
1113
github.ibm.com/alchemy-containers/armada-opensource-lib,v0.4.4
14+
github.ibm.com/alchemy-containers/go-build-tools,v0.1.18
1215
go.uber.org/zap,v1.14.0
1316
golang.org/x/time,v0.0.0-20191024005414-555d28b269f0
1417
k8s.io/api,v0.19.2

block-storage-attacher/go.mod

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,16 @@ require (
66
github.com/BurntSushi/toml v0.3.1
77
github.com/blang/semver v3.5.1+incompatible
88
github.com/coreos/go-systemd/v22 v22.1.0
9-
github.com/onsi/ginkgo v1.11.0
10-
github.com/onsi/gomega v1.7.0
9+
github.com/onsi/ginkgo v1.12.0
10+
github.com/onsi/gomega v1.9.0
1111
github.com/opencontainers/selinux v1.6.0
12+
github.com/pierrre/gotestcover v0.0.0-20160517101806-924dca7d15f0 // indirect
1213
github.com/satori/go.uuid v1.2.0
14+
github.com/securego/gosec v0.0.0-20200401082031-e946c8c39989 // indirect
1315
github.com/spf13/viper v1.7.1
1416
github.com/stretchr/testify v1.4.0
17+
github.ibm.com/alchemy-containers/armada-opensource-lib v0.4.4 // indirect
18+
github.ibm.com/alchemy-containers/go-build-tools v0.1.18 // indirect
1519
go.uber.org/zap v1.14.0
1620
golang.org/x/time v0.0.0-20191024005414-555d28b269f0
1721
k8s.io/api v0.19.2

0 commit comments

Comments
 (0)