feat: optimize BigInt conversion by adding support for short BigInt

Author: Icemic

libquickjs-sys/embed/extensions.c

@@ -77,6 +77,11 @@ int JS_Ext_GetInt(JSValue v)
     return JS_VALUE_GET_INT(v);
 }
 
+int JS_Ext_GetShortBigInt(JSValue v)
+{
+    return JS_VALUE_GET_SHORT_BIG_INT(v);
+}
+
 int JS_Ext_GetBool(JSValue v)
 {
     return JS_VALUE_GET_BOOL(v);

libquickjs-sys/embed/extensions.h

@@ -19,6 +19,7 @@ extern "C"
   bool JS_Ext_IsNan(JSValue v);
   double JS_Ext_GetFloat64(JSValue v);
   int JS_Ext_GetInt(JSValue v);
+  int JS_Ext_GetShortBigInt(JSValue v);
   int JS_Ext_GetBool(JSValue v);
   void *JS_Ext_GetPtr(JSValue v);
   int JS_Ext_GetNormTag(JSValue v);

src/value/value.rs

@@ -320,13 +320,13 @@ impl OwnedJsValue {
             });
         }
 
-        // let mut int: i64 = 0;
-        // let ret = unsafe { q::JS_ToBigInt64(self.context, &mut int, self.value) };
-        // if ret == 0 {
-        //     Ok(BigInt {
-        //         inner: BigIntOrI64::Int(int),
-        //     })
-        // } else {
+        if self.is_short_bigint() {
+            let int = unsafe { q::JS_Ext_GetShortBigInt(self.value) };
+            return Ok(BigInt {
+                inner: BigIntOrI64::Int(int as i64),
+            });
+        }
+
         let ret = unsafe { q::JS_Ext_BigIntToString1(self.context, self.value, 16) };
         let ret = OwnedJsValue::new(self.context, ret);
 

tests/runtime.rs

@@ -664,10 +664,16 @@ fn chrono_roundtrip() {
 #[cfg(feature = "bigint")]
 #[test]
 fn test_bigint_deserialize_i64() {
-    for i in [0, std::i64::MAX, std::i64::MIN] {
+    for i in [0, std::i32::MAX as i64 / 2, std::i64::MAX, std::i64::MIN] {
         let c = Context::builder().build().unwrap();
         let value = c.eval(&format!("{}n", i), false).unwrap();
         assert_eq!(value.to_bigint(), Ok(i.into()));
+        if i.unsigned_abs() <= std::i32::MAX as u64 {
+            assert!(value.is_short_bigint());
+        } else {
+            assert!(!value.is_short_bigint());
+            assert!(value.is_bigint());
+        }
     }
 }