Freshly create plot schematic is regenerated (cleared) one block too low #4404
Description
Server Implementation
Paper
Server Version
1.20.4
Describe the bug
When clearing a plot in an area utilizing plot schematics, the schematic will be pasted one block too low.
World-Generation itself works (e.g. //regen works).
The culprit seems to be somewhere here (used by the FAWE Delegate to determine minY for plot schematics):
When replacing SCHEM_Y + plotY with getMinBuildHeight() (the same reference point the world generator uses, as visible in HybridGen: https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/generator/HybridGen.java#L76) clear works. My only idea for that being is, that one of these two variables is normalized somewhere - possibly against the road height.
I don't just want to PR my fix, as I'm not sure what the reasoning behind the change was (@dordsor21 ?) and if that does not have any unexpected side effects.
To Reproduce
- Create plot schematic as described in wiki (
/plot schematic save, move to appropriate schematic folder) - World will be generated accordingly
- Claim Plot and run
/plot clear - Schematic will be one block too low
Expected behaviour
The schematic should be pasted from the correct y-level
Screenshots / Videos
No response
Error log (if applicable)
No response
Fawe Debugpaste
Fawe Version
Checklist
- I have included a Fawe debugpaste.
- I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.
Anything else?
No response