From 3e755ddd515e03ef534648b46d40bef51c02c38b Mon Sep 17 00:00:00 2001 From: Mitchell O'Sullivan Date: Fri, 19 May 2023 01:13:00 +1000 Subject: [PATCH] Update dialog JavaScript for newer Electron API Differences in the security model of later versions of Electron meant that a few tweaks were necessary to ensure compatibility with the latest updates to Blink.jl --- src/input.jl | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/input.jl b/src/input.jl index 43c00ab..4105862 100644 --- a/src/input.jl +++ b/src/input.jl @@ -97,17 +97,12 @@ function dialog(theme::WidgetTheme, dialogtype; value, className = "", label = " setobservable!(scp, "output", value) clicks = Observable(scp, "clicks", 0) callback = @js function (val) - $value[] = val + console.log(val); + $value[] = val; end - onimport(scp, js""" - function () { - const { dialog } = require('electron').remote; - this.dialog = dialog; - } - """) onjs(clicks, js""" function (val) { - console.log(this.dialog.$dialogtype($options, $callback)); + window.dialog.$dialogtype($options, $callback); } """) className = mergeclasses(getclass(theme, :button), className)