fixup! Drop Formatting.jl

Author: nickrobinson251

src/LinuxPerf.jl

@@ -359,8 +359,8 @@ struct Counters
     counters::Vector{Counter}
 end
 
-addcommas(i::Int) = addcommas(string(i))
-function addcommas(s::String)
+_addcommas(i::Int) = _addcommas(string(i))
+function _addcommas(s::String)
     len = length(s)
     t = ""
     for i in 1:3:len
@@ -383,7 +383,7 @@ function Base.show(io::IO, c::Counters)
     stats  = mapreduce(vcat, c.counters) do c
         c.enabled == 0 ? ["never enabled" "0 %"] :
             c.running == 0 ? ["did not run" "0 %"] :
-                [addcommas(Int64(c.value)) @sprintf("%.1f %%", 100*(c.running/c.enabled))]
+                [_addcommas(Int64(c.value)) @sprintf("%.1f %%", 100*(c.running/c.enabled))]
     end
     return pretty_table(io, stats, header=["Events", "Active Time"], row_labels=events, alignment=:l, crop=:none, body_hlines=collect(axes(stats, 1)))
 end

test/runtests.jl

@@ -97,5 +97,13 @@ end
     @pstats "cpu-cycles,(instructions,branch-instructions,branch-misses),(task-clock,context-switches,cpu-migrations,page-faults),(L1-dcache-load-misses,L1-dcache-loads,L1-icache-load-misses),(dTLB-load-misses,dTLB-loads)" foo!(dest, a, b, c)
 end
 
+@testset "_addcommas" begin
+    @test LinuxPerf._addcommas(1) == "1"
+    @test LinuxPerf._addcommas(12) == "12"
+    @test LinuxPerf._addcommas(123) == "123"
+    @test LinuxPerf._addcommas(1234) == "1,234"
+    @test LinuxPerf._addcommas(12345) == "12,345"
+    @test LinuxPerf._addcommas(typemin(Int64)) == "-9,223,372,036,854,775,808"
+end
 
 end