ReadOnly: slightly restrict the dispatch on the setindex! method (#652)

nsajko · web-flow · commit 15ec056bd5b0 · 2025-09-21T12:07:05.000+02:00
diff --git a/src/readonly.jl b/src/readonly.jl
@@ -22,7 +22,7 @@ end
 
 Base.unsafe_convert(x::Type{Ptr{T}}, A::ReadOnly) where T = Base.unsafe_convert(x, parent(A))
 Base.elsize(::Type{ReadOnly{T,N,V}}) where {T,N,V} = Base.elsize(V)
-Base.@propagate_inbounds @inline Base.setindex!(x::ReadOnly, v, ind...) = if v == getindex(parent(x), ind...)
+Base.@propagate_inbounds @inline Base.setindex!(x::ReadOnly, v, ind::Vararg{Integer}) = if v == getindex(parent(x), ind...)
         v
     else
         error("Can't change $(typeof(x)).")

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ end`
`22`	`22`
`23`	`23`	`Base.unsafe_convert(x::Type{Ptr{T}}, A::ReadOnly) where T = Base.unsafe_convert(x, parent(A))`
`24`	`24`	`Base.elsize(::Type{ReadOnly{T,N,V}}) where {T,N,V} = Base.elsize(V)`
`25`		`-Base.@propagate_inbounds @inline Base.setindex!(x::ReadOnly, v, ind...) = if v == getindex(parent(x), ind...)`
	`25`	`+Base.@propagate_inbounds @inline Base.setindex!(x::ReadOnly, v, ind::Vararg{Integer}) = if v == getindex(parent(x), ind...)`
`26`	`26`	`v`
`27`	`27`	`else`
`28`	`28`	`error("Can't change $(typeof(x)).")`