Specialize apply_schema to Schema for lead/lag (#152)

* specialize lead/lag apply schema to Schema

* add test to detect ambiguities in StatsModels

* test ambiguities first, leave broken test in extensions

adding additional methods in the extensions tests creates ambiguities :(((

Author: kleinschmidt

src/StatsModels.jl

@@ -58,8 +58,8 @@ export
 include("traits.jl")
 include("contrasts.jl")
 include("terms.jl")
-include("temporal_terms.jl")
 include("schema.jl")
+include("temporal_terms.jl")
 include("formula.jl")
 include("modelframe.jl")
 include("statsmodel.jl")

src/temporal_terms.jl

@@ -26,7 +26,7 @@ struct LeadLagTerm{T<:AbstractTerm, F<:Union{typeof(lead), typeof(lag)}} <: Abst
     nsteps::Int
 end
 
-function apply_schema(t::FunctionTerm{F}, sch, ctx::Type) where F<:Union{typeof(lead), typeof(lag)}
+function apply_schema(t::FunctionTerm{F}, sch::Schema, ctx::Type) where F<:Union{typeof(lead), typeof(lag)}
     opname = string(nameof(F.instance))
     if length(t.args_parsed) == 1  # lag(term)
         term_parsed = first(t.args_parsed)

test/ambiguity.jl

@@ -0,0 +1,3 @@
+@testset "Ambiguity detection" begin
+    @test isempty(Test.detect_ambiguities(StatsModels))
+end

test/extension.jl

@@ -93,4 +93,9 @@ end
     @testset "Fallback" begin
         @test_throws ArgumentError modelcols(DummyTerm(), (a=[1], ))
     end
+
+    @testset "Ambiguity detection" begin
+        # ambiguities are introduced by adding additional methods here
+        @test_broken isempty(Test.detect_ambiguities(StatsModels))
+    end
 end

test/runtests.jl

@@ -8,7 +8,8 @@ using StatsBase
 
 using StatsModels: ContrastsMatrix
 
-my_tests = ["formula.jl",
+my_tests = ["ambiguity.jl",
+            "formula.jl",
             "terms.jl",
             "temporal_terms.jl",
             "schema.jl",