Skip to content

Fix broken encapsulation #32

@jfri3d

Description

@jfri3d

What is the current behaviour?

Minimal bug found within JobService where it accesses pachyderm clients directly.

if not self.client.check_branch_exists(repo=pipeline_name, branch=pipeline_def["output_branch"]):
    self.client.pfs_client.create_branch(repo_name=pipeline_name, branch_name=pipeline_def["output_branch"])

What is the expected behaviour?

self.client.pfs_client is a violation!!!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions