fix(controlplane): Remove the check of listener programmed condition in extracting certificates #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
changed the title
programmer04
previously approved these changes
Aug 11, 2025
randmonkey
force-pushed
the
fix/do_not_skip_gateway_listener_certs
branch
from
00c7ebe to
8743cc7
Compare
programmer04
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the check of
Programmedcondition in listeners when extracting certificates from them to fix the disappearance of certificates when dataplane pods changed.Since in this repo
ingress-controllerdoes not run as a standalone KIC and will not reconcile the "Unmanaged" gateways, we do not need to check the gateway or gateway class to decide whether it should run the check.Which issue this PR fixes
Part of #1769
Special notes for your reviewer:
Same as Kong/kubernetes-ingress-controller#7666 but we do not need to check the
GatewayClassas standalone KIC still need to reconcile "Unmanged" gateways, but the embedded controllers in KO does not need to.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes