Skip to content

Commit 74427c2

Browse files
committed
fix(forms): remove data contamination
1 parent bcfd445 commit 74427c2

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

packages/core/forms/src/components/fields/FieldAutoSuggestV2.vue

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<template #item="{ item }">
3333
<div class="entity-suggestion-item">
3434
<span class="entity-label">
35-
{{ item.label }}
35+
{{ item.label || LABEL_PLACEHOLDER }}
3636
</span>
3737
<span class="entity-id">
3838
{{ item.id }}
@@ -42,7 +42,7 @@
4242

4343
<template #selected-item="{ item }">
4444
<span class="selected-entity-item">
45-
<span class="selected-entity-label">{{ item.__no_name ? item.value : item.label }}</span>
45+
<span class="selected-entity-label">{{ item.label ?? item.value }}</span>
4646
</span>
4747
</template>
4848
</FieldScopedEntitySelect>
@@ -61,7 +61,6 @@ import english from '../../locales/en.json'
6161
6262
const requestResultsLimit = 1000
6363
const LABEL_PLACEHOLDER = '-'
64-
const NO_NAME_SYMBOL = Symbol('no_name')
6564
6665
export default {
6766
components: {
@@ -184,13 +183,11 @@ export default {
184183
},
185184
186185
transformItem(item) {
187-
const label = this.getSuggestionLabel(item)
188186
return {
189187
...item,
190188
// This field is for select dropdown item first column.
191-
label: label === NO_NAME_SYMBOL ? LABEL_PLACEHOLDER : label,
189+
label: this.getSuggestionLabel(item),
192190
value: item.id,
193-
...(label === NO_NAME_SYMBOL ? { __no_name: true } : {}),
194191
}
195192
},
196193
@@ -224,7 +221,7 @@ export default {
224221
225222
getSuggestionLabel(item) {
226223
const labelKey = this.schema?.labelField || 'id'
227-
return (labelKey && item ? item[labelKey] : '') || NO_NAME_SYMBOL
224+
return labelKey && item ? item[labelKey] : ''
228225
},
229226
230227
updateModel(value) {

0 commit comments

Comments
 (0)