Skip to content

Commit b78cbea

Browse files
authored
refactor(entities-vaults): always enable config store for konnect (#2627)
1 parent c7875d5 commit b78cbea

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

packages/entities/entities-vaults/docs/vault-form.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,6 @@ A form component for Vaults.
7474
- *Specific to Konnect*. Show/hide Azure option.
7575
- **Note:** This is experimental and not supported by the backend right now
7676

77-
- `konnectConfigStoreAvailable`
78-
- type: `boolean`
79-
- required: `false`
80-
- default: `undefined`
81-
- *Specific to Konnect*. Show/hide Konnect Config Store option.
82-
8377
- `ttl`
8478
- type: `boolean`
8579
- required: `true`

packages/entities/entities-vaults/sandbox/pages/VaultFormPage.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ const konnectConfig = ref<KonnectVaultFormConfig>({
3838
azureVaultProviderAvailable: true,
3939
ttl: true,
4040
hcvAppRoleMethodAvailable: true,
41-
konnectConfigStoreAvailable: true,
4241
conjurVaultProviderAvailable: true,
4342
})
4443

packages/entities/entities-vaults/src/components/VaultForm.cy.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const baseConfigKonnect: KonnectVaultFormConfig = {
1111
apiBaseUrl: '/us/kong-api',
1212
cancelRoute,
1313
azureVaultProviderAvailable: false,
14-
konnectConfigStoreAvailable: true,
1514
ttl: true,
1615
}
1716

@@ -21,7 +20,6 @@ const baseConfigKonnectTurnOffTTL: KonnectVaultFormConfig = {
2120
apiBaseUrl: '/us/kong-api',
2221
cancelRoute,
2322
azureVaultProviderAvailable: false,
24-
konnectConfigStoreAvailable: true,
2523
ttl: false,
2624
}
2725

packages/entities/entities-vaults/src/components/VaultForm.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ const originalFields = reactive<VaultStateFields>({
763763
tags: '',
764764
})
765765
766-
const vaultProvider = ref<VaultProviders>(props.config.konnectConfigStoreAvailable ? VaultProviders.KONNECT : VaultProviders.ENV)
766+
const vaultProvider = ref<VaultProviders>(props.config.app === 'konnect' ? VaultProviders.KONNECT : VaultProviders.ENV)
767767
const originalVaultProvider = ref<VaultProviders | null>(null)
768768
const configStoreId = ref<string>()
769769
@@ -774,7 +774,7 @@ const isAvailableTTLConfig = computed(() => {
774774
const providers = computed<Array<{ label: string, value: VaultProviders }>>(() => {
775775
return [
776776
...(
777-
props.config.konnectConfigStoreAvailable
777+
props.config.app === 'konnect'
778778
? [{
779779
label: t('form.config.konnect.label'),
780780
value: VaultProviders.KONNECT,

packages/entities/entities-vaults/src/types/vault-form.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,10 @@ export interface BaseVaultFormConfig extends Omit<BaseFormConfig, 'cancelRoute'>
2424
* Show/hide cert option and corresponding fields
2525
*/
2626
hcvCertMethodAvailable?: boolean
27+
2728
/**
28-
* Show/hide Konnect Config Store option
29-
*/
30-
konnectConfigStoreAvailable?: boolean
31-
/**
32-
* Show/hide AWS StsEndpointUrl field
33-
*/
29+
* Show/hide AWS StsEndpointUrl field
30+
*/
3431
awsStsEndpointUrlAvailable?: boolean
3532

3633
/**

0 commit comments

Comments
 (0)