Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Commit 2b18ec2

Browse files
committed
Fixed bugs: Failing deserialization of Element and SimpleContext-classes; Failing SentencePreprocessorTest.
1 parent 4fc82df commit 2b18ec2

File tree

5 files changed

+13
-1
lines changed

5 files changed

+13
-1
lines changed

src/main/java/org/lambda3/text/simplification/discourse/model/Element.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
package org.lambda3.text.simplification.discourse.model;
2424

25+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
2526
import com.fasterxml.jackson.annotation.JsonProperty;
2627
import edu.stanford.nlp.trees.Tree;
2728
import org.lambda3.text.simplification.discourse.utils.IDGenerator;
@@ -36,6 +37,7 @@
3637
/**
3738
*
3839
*/
40+
@JsonIgnoreProperties(ignoreUnknown = true)
3941
public class Element {
4042
private String id;
4143
private Tree parseTree;

src/main/java/org/lambda3/text/simplification/discourse/model/SimpleContext.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
package org.lambda3.text.simplification.discourse.model;
2424

25+
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
2526
import com.fasterxml.jackson.annotation.JsonProperty;
2627
import edu.stanford.nlp.trees.Tree;
2728
import org.lambda3.text.simplification.discourse.runner.discourse_tree.Relation;
@@ -34,6 +35,7 @@
3435
import java.util.regex.Matcher;
3536
import java.util.regex.Pattern;
3637

38+
@JsonIgnoreProperties(ignoreUnknown = true)
3739
public class SimpleContext {
3840
private static final Pattern PHRASE_PATTERN = Pattern.compile("^\\W*this\\W+\\w+\\W+(?<phrase>.*\\w+.*)$", Pattern.CASE_INSENSITIVE);
3941
private static final Pattern ATTRIBUTION_PHRASE_PATTERN = Pattern.compile("^\\W*this\\W+\\w+\\W+what\\W+(?<phrase>.*\\w+.*)$", Pattern.CASE_INSENSITIVE);

src/main/java/org/lambda3/text/simplification/discourse/processing/SentencePreprocessor.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,16 @@ public class SentencePreprocessor {
3737

3838
private static String WHITESPACE_PATTERN = "\\s+";
3939

40-
public final boolean removeBrackets;
40+
public boolean removeBrackets;
4141

4242
public SentencePreprocessor(Config config) {
4343
this.removeBrackets = config.getBoolean("remove-brackets");
4444
}
4545

46+
public void setRemoveBrackets(boolean removeBrackets) {
47+
this.removeBrackets = removeBrackets;
48+
}
49+
4650
public String preprocessSentence(String sentence) {
4751
String res = sentence;
4852

src/test/java/org/lambda3/text/simplification/discourse/processing/DiscourseSimplifierTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ void serializationTest() throws IOException {
6262
log.info("LOAD FROM FILE...");
6363
SimplificationContent loaded = SimplificationContent.deserializeFromJSON(new File(filename), SimplificationContent.class);
6464

65+
log.info(loaded.prettyPrintJSON());
66+
log.info("---------------------------------");
6567
log.info(loaded.defaultFormat(false));
6668

6769
log.info("DELETE FILE...");

src/test/java/org/lambda3/text/simplification/discourse/processing/SentencePreprocessorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ public class SentencePreprocessorTest {
3333

3434
@Test
3535
void preprocessSentence() {
36+
preprocessor.setRemoveBrackets(true);
37+
3638
String sentence = "This is a test (in brackets) and [the last (one)].";
3739
String sentence2 = "This is -LRB- a second test -RRB-.";
3840

0 commit comments

Comments
 (0)