Assault Containerization + Framework

Updates Assaults to use the Container framework to allow for global lookups.
All existing assaults will continue to perform as expected. This framework will not effect their performance.
This commit also aims to simplify the creation and maintenance of assaults by moving all relevant information into 1 instance file, moreover it allows assaults to more easily make use of the dynamic ID system and move away from the need of hardcoded ID definitions.
Builds a scalable framework that would allow for easy customization where needed by creating overwritable functions in the container constructor itself.
Updates assault Extermination to use the framework as an example
Implemented missing framework to Ilrusi Atoll
Globalized assault mission giver behavior (save nyzul isle)
Added an experimental tag that can be toggled

Sanity checks + PR change requests

Attempt to fix sanity checks by turning instanceAssault into a local and passed through xi.assault

Fixed PR requests
- Use zoneID binding instead of getZone():getID()
- Typo
- Better ID lookups for undead mob spawning

Sanity Fixes

More Sanity fixes with bad lua styling

Move function overrides

Move function overrides into the InstanceAssault container itself

Author: dallano

scripts/enum/assault.lua

@@ -57,7 +57,7 @@ xi.assault.mission =
     THE_PRICE_IS_RIGHT                = 40,
     GOLDEN_SALVAGE                    = 41,
     LAMIA_NO_13                       = 42,
-    EXTERMINATION                     = 43,
+    EXTERMINATION                     = 43, -- Experimental
     DEMOLITION_DUTY                   = 44,
     SEARAT_SALVATION                  = 45,
     APKALLU_SEIZURE                   = 46,
@@ -69,6 +69,71 @@ xi.assault.mission =
     NYZUL_ISLE_UNCHARTED_AREA_SURVEY  = 52,
 }
 
+---@enum xi.instanceID
+xi.assault.instanceID =
+{
+    -- Ilrusi Atoll
+    GOLDEN_SALVAGE                  = 5500,
+    LAMIA_NO_13                     = 5501,
+    EXTERMINATION                   = 5502,
+    DEMOLITION_DUTY                 = 5503,
+    SEARAT_SALVATION                = 5504,
+    APKALLU_SEIZURE                 = 5505,
+    LOST_AND_FOUND                  = 5506,
+    DESERTER                        = 5507,
+    DESPERATELY_SEEKING_CEPHALOPODS = 5508,
+    BELLEROPHONS_BLISS              = 5509,
+
+    -- Periqia
+    SEAGULL_GROUNDED                = 5601,
+    REQUIEM                         = 5602,
+    SAVING_PRIVATE_RYAAF            = 5603,
+    SHOOTING_DOWN_THE_BARON         = 5604,
+    BUILDING_BRIDGES                = 5605,
+    STOP_THE_BLOODSHED              = 5606,
+    DEFUSE_THE_THREAT               = 5607,
+    OPERATION_SNAKE_EYES            = 5608,
+    WAKE_THE_PUPPET                 = 5609,
+    THE_PRICE_IS_RIGHT              = 5610,
+
+    -- Lebros Cavern
+    EXCAVATION_DUTY                 = 6300,
+    LEBROS_SUPPLIES                 = 6301,
+    TROLL_FUGITIVES                 = 6302,
+    EVADE_AND_ESCAPE                = 6303,
+    SIEGEMASTER_ASSASSINATION       = 6304,
+    APKALLU_BREEDING                = 6305,
+    WAMOURA_FARM_RAID               = 6306,
+    EGG_CONSERVATION                = 6307,
+    OPERATION_BLACK_PEARL           = 6308,
+    BETTER_THAN_ONE                 = 6309,
+
+    -- Mamool Ja Training Grounds
+    IMPERIAL_AGENT_RESCUE           = 6600,
+    PREEMPTIVE_STRIKE               = 6601,
+    SAGELORD_ELIMINATION            = 6602,
+    BREAKING_MORALE                 = 6603,
+    THE_DOUBLE_AGENT                = 6604,
+    IMPERIAL_TREASURE_RETRIEVAL     = 6605,
+    BLITZKRIEG                      = 6606,
+    MARIDS_IN_THE_MIST              = 6607,
+    AZURE_AILMENTS                  = 6608,
+    THE_SUSANOO_SHUFFLE             = 6609,
+
+    -- Leujaoam Sanctum
+    LEUJAOAM_CLEANSING              = 6900,
+    ORICHALCUM_SURVEY               = 6901,
+    ESCORT_PROFESSOR_CHANOIX        = 6902,
+    SHANARHA_GRASS_CONSERVATION     = 6903,
+    COUNTING_SHEEP                  = 6904,
+    SUPPLIES_RECOVERY               = 6905,
+    AZURE_EXPERIMENTS               = 6906,
+    IMPERIAL_CODE                   = 6907,
+    RED_VERSUS_BLUE                 = 6908,
+    BLOODY_RONDO                    = 6909,
+}
+
+-- TODO: Delete this table after conversion is complete
 ---@enum xi.missionInfo
 xi.assault.missionInfo =
 {