Skip to content

Conversation

@nathanhhughes
Copy link
Contributor

@jingnanshi This bundles a few loosely related changes:

  • Switches to FetchContent instead of the old manual method for downloading source dependencies
  • Switches PMC to be built and linked statically to avoid needed to install the library, and doesn't install spectra or tinyply (because they're header only and privately included)
  • Updates the github actions file to use newer versions of ubuntu and adds a quick python CI test
  • Removes the need for any of the RPATH shenanigans that was going on previously by statically linking registration into the python bindings

The changes (to the python bindings) mean that the python documentation is a little out of date and the conda recipes are broken, happy to go fix it at some point if you care about that

@GoldenZephyr this fixes the issue you were seeing if you want to point to this instead of the temporary fix you had

revert to original pmc repo

update github workflows

switch back to downloaded gtest

drop gtest deps and add python workflow

add import test

fix missing quote

static python build

fix python installation
@jingnanshi
Copy link
Member

@nathanhhughes looks great!

@jingnanshi jingnanshi merged commit f91cfdb into MIT-SPARK:master May 12, 2025
3 checks passed
@nathanhhughes nathanhhughes deleted the fix/third_party branch May 12, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants